In Nodejs, the global variable in my app.js file is undefined in another file

Question

I am in a project using Nodejs, and its Express framework.

In the main archive app js. i call a function in order to read a file, and assign to a global variable:

global.google_sheet_credentials = readFileCredentials("spread_sheet.txt");

The code of the function readFileCredentialls is:

readFileCredentials = function(file){
    fs.readFile('data-source/credentials/'+file, 'utf8', function(err, data){
        if(err){
            console.log("Could not open file: %s", err);
        }else{
            console.log(data);
            return data;
        }
    });
};

module.exports = readFileCredentials;

After that, I redirect to another file:

rek('dashboards/ti/main_it');

In this file main_it.js, i try to use this global variable google_sheet_credentials:

console.log(google_sheet_credentials);

but warns that it is undefined, someone can explain to me the reason, and a way for me to get the right result?

Answer 1

This function is asynchronous, that is to say return is not used the way you think.

You have to wear a callback (or via Promise as suggested in another reply). Thus, you can only count on the value set in that global.google_sheet_credentials when the callback is called.

A suggestion would be so:

readFileCredentials = function(file, cb){
    var _path = 'data-source/credentials/' + file;
    fs.readFile(_path, 'utf8', function(err, data){
        if(err){
            console.log("Could not open file: %s", err);
        }
        cb(err, data); 
    });
};

module.exports = readFileCredentials;

and then use it like this:

readFileCredentials("spread_sheet.txt", function(err, data){
    global.google_sheet_credentials = data;
    // agora a variável está setada. Se precisares de correr outro código tens de o ter aqui dentro, ou chamando funções a partir daqui
});

Answer 2

Clearly your code problem is with asynchrony. Promises can solve your problem:

function readFileCredentials(file) {
    return new Promise(function(resolve, reject) {
        fs.readFile('data-source/credentials/' + file, 'utf8', function(err, data){
            if (err) {
                console.log("Could not open file: %s", err);
                reject(err);
            } else {
                resolve(data);
            }
        });
    });
};

module.exports = readFileCredentials;

On the call, just use the then to continue the Promise process:

readFileCredentials("spread_sheet.txt").then(function(googleSheetCredentials) {
    global.google_sheet_credentials = googleSheetCredentials;
});

Updating:

As the link that was passed, try to modify your App code to work as follows:

var App = (function(){

    // Method Construct, your objetive is loading modules and utils that will be used in this project.
    function App() {
        this.define_global_utils(function() {
          this.define_global_modules();
        }.bind(this));

        this.init();
    }

    // Method responsible for initiating the application.
    App.prototype.init = function(){
        this.load_modules();
    };

    // Method responsible for importing the modules used in this project.
    // The modules were imported globally, that is, can be used in anywhere in the code.
    App.prototype.define_global_modules = function() {
        global.rek = require('rekuire');
        global.fs = require('fs');
    };

    // Method responsible for imported the utilities.
    App.prototype.define_global_utils = function(callback){
        global.readFileCredentials = rek('data-source/utils/readFileCredentials');

        readFileCredentials("spread_sheet.txt", function(err, data){
            global.google_sheet_credentials = data;
            callback();
            // agora a variável está setada. Se precisares de correr outro código tens de o ter aqui dentro, ou chamando funções a partir daqui
        });
    };

    // Method responsible for loading the dashboards.
    App.prototype.load_modules = function(){
        rek('dashboards/implantation/main_implantation');
    };

    return App;
})();