Laravel 4 (Eloquent) Error deleting records

Question

Hello, in this code below I delete the database of the selected records in a list of chekboxes.

I have an array of Ids that is mounted as follows:

Array (
    [0] => 810
    [1] => 811
)

On top of this array I do a foreach search each record and call the exclusion method, complete code below:

public function destroy_download($id = 0){
    $ids = ($id >= 1) ? array($id) : Input::get('ids');

    if( ! empty($ids) ){
        foreach ($ids as $id) {
            $download = Download::find($id);
            $download->delete();
        }
    }
}

This should work properly, however gives the following error:

Symfony \ Component \ Debug \ Exception \ FatalErrorException Call to a member function delete() on a non-object

on the line:

$download->delete();

It’s like the record hasn’t been found.

It removes the record in the database only if this error happens, someone can imagine what it is?

The Array is correct, I’ve debugged but always gives it.

Answer 1

Try the following:

public function destroy_download($id = 0){
    $ids = ($id >= 1) ? array($id) : Input::get('ids');

    if( ! empty($ids) ){
        foreach ($ids as $id) {
            try {
                Download::findOrFail($id)->delete();
            } catch (ModelNotFoundException $e){
                continue;
            }
        }
    }
}

This code will attempt to delete the id, if it does not find this record, it goes to the next.

Suggestion: I think it’s good to review this method, the way it is we have unnecessary variable checks $ids

public function destroyDownloads(){
    $ids = Input::get('ids');

    // Não é um array? Aborta a função
    if(!is_array($ids)){
        return false;
    }

    foreach ($ids as $id){
        $this->deleteDownload($id);
    }

    // Ou returne um Response::make()
    return true;

}

private function deleteDownload($id){

    try {
        Download::findOrFail($id)->delete();
    } catch (ModelNotFoundException $e){
        // Caso queira verificar erros no futuro, basta verificar com um if
        // o retorno de $this->deleteDownload($id), se for falso o registro não existia
        return false;
    }

    return true;
}

Answer 2

Confirm that the ID of the object exists, interpreting the result a little, looks like the function Download::find($id); returns a string/null when the Id does not exist, therefore when Voce tries to call the method delete() generates this error.

Create a check to confirm that the ID actually exists before calling delete().