Foreach duplicating the data

Question

I possess 2 foreachs, to search for dates on ViewBags, where I return both in a select.

But for each item of the first foreach, it makes a complete loop in the second, thus doubling the values, for each item of the first.

Ex: If I have 3 items in the first foreach and 2 items in the second, my final result will be 6 items in my select, and it repeats the data, after the loop of the first.

My problem is: How to do not repeat this data?

My Foreahcs in the view:

<div class="col-md-9">
                        <select class="form-control" style="width:250px" id="selectPeriodo" name="sAquisitivo">
                            @foreach (var date in ViewBag.Ferias)
                            {
                                foreach (var fim in ViewBag.FimFerias)
                                {
                                    <option>
                                        @Convert.ToDateTime(date).ToShortDateString() à @Convert.ToDateTime(fim).ToShortDateString()
                                    </option>
                                }
                            }
                        </select>
                    </div>

My Viewbags:

 ViewBag.Ferias = funcionarioFeriasRepository.Lista.Where(r => r.CdMatricula == matricula && r.SqContrato == contrato && r.DtInicioConcessao == null)
            .Select(x => x.DtInicioPeriodo).ToList();
            ViewBag.FimFerias = funcionarioFeriasRepository.Lista.Where(r => r.CdMatricula == matricula && r.SqContrato == contrato && r.DtInicioConcessao == null)
            .Select(x => x.DtFimPeriodo).ToList();

Entity:

[DataType(DataType.Date)]
        [DisplayFormat(DataFormatString = "{0:dd/MM/yyyy}", ApplyFormatInEditMode = true)]
        public DateTime? dtInicioFerias { get; set; }

        [DataType(DataType.Date)]
        [DisplayFormat(DataFormatString = "{0:dd/MM/yyyy}", ApplyFormatInEditMode = true)]
        public DateTime? dtFimFerias { get; set; }

        public string sAquisitivo { get; set; }

Upshot:

Remembering that I am working with Foreachs, because it was the only option I could find to format the dates to the dd/MM/yyyy format. Because they in a Dropdownlist were not formatted, even using toString() and adding annotations in the model.

Answer 1

I believe this is what you want. I see no reason for two foreachs. This solution was given because the viewBag was created in the wrong way. So she would look like this:

ViewBag.Ferias = funcionarioFeriasRepository.Lista.Where(r => r.CdMatricula == matricula && r.SqContrato == contrato && r.DtInicioConcessao == null)
        .Select(x => new { Inicio = x.DtInicioPeriodo, Fim = x.DtFimPeriodo}).ToList();

I did the conversion there but you may not do if you need the data without conversion elsewhere. But in general it is not the right, the view must have as little processing as possible. Then the view will look like this:

<div class="col-md-9">
    <select class="form-control" style="width:250px" id="selectPeriodo" name="sAquisitivo">
        @foreach (var date in ViewBag.Ferias) {
            <option>
                @Convert.ToDateTime(date.Inicio).ToShortDateString() à @Convert.ToDateTime(date.Fim).ToShortDateString()
            </option>
        }
    </select>
</div>

I put in the Github for future reference.

I have no way to test, maybe you have to make some adaptation to work but the general idea is this.

Answer 2

As posted by @Maniero, the view should have as little processing as possible, ideally you simply display the value in the view and not keep converting data etc...

Consider the code below only if you can’t implement as @Maniero suggested. But focusing on your foreach, I believe you can try to assemble these values without duplicating the dates like this:

...
@for(int i = 0; i < ViewBag.Ferias.Count(); i++)
{
   var l = 0;
   while(l < 1)
   {
      <option>
              @Convert.ToDateTime(ViewBag.Ferias[i]).ToShortDateString() à @Convert.ToDateTime(ViewBag.FimFerias[i]).ToShortDateString()
       </option>
      l++;
   }
}
...

---

Editing:

Removed the parentheses of ViewBag.Ferias.Count in the for.

Removed the While, I had entered it in the code above when I was reasoning about the 2 foreachs, but it is not necessary.

...
@for(int i = 0; i < ViewBag.Ferias.Count; i++)
{
      <option>
              @Convert.ToDateTime(ViewBag.Ferias[i]).ToShortDateString() à @Convert.ToDateTime(ViewBag.FimFerias[i]).ToShortDateString()
       </option>
}
...