Error while adding strings to an array

Question

My Activity of an Android app has this code.

public class gerenciar2 extends ActionBarActivity{
    boolean editar=false, adcionar=false, remover=false;
    SQLiteDatabase Banco = null;
    Cursor cursor;
    String tabbanco="Tabela1";
    TextView gerenciar;
    ListView lista;
    String tabelas[];
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.gerenciamento);
        lista = ( ListView ) findViewById(R.id.list);
        abrebanco();
        buscardados();
        gerelista();


        }



    public void gerelista() {
        cursor.moveToLast();
        int x=cursor.getCount();
        int y=1;
        while(y<x){
        //nextdado();   
        tabelas[x]=retornadado();   
        dadoanterior();
        y++;
        };
        //return tabelas;

    }


    public boolean dadoanterior() {
        try{
            cursor.moveToPrevious();
            return true;

        }
        catch(Exception erro){
            return false;

        }

    }

    public boolean buscardados(){
        try{
            cursor = Banco.query("tabela",
                    new String [] {"tabelas",}
            , null, null, null, null, null);

            if (cursor.getCount() != 0){
                cursor.moveToFirst();

            }else{
                String sql = "INSERT INTO tabela (tabelas) " +
                          "values (Tabela1) ";
                    Banco.execSQL(sql);
            }

            return true;
        }
        catch(Exception erro){
            Exibirmensagem("BANCO", "erro ao buscar no banco: "+ erro.getMessage(), "ok");
            return false;
        }
    }
    public String retornadado(){
        String dado = cursor.getString(cursor.getColumnIndex("tabelas"));
        return dado;
    }
    public void abrebanco(){
        try{
            Banco = openOrCreateDatabase("banco", MODE_WORLD_WRITEABLE, null);
            String sql ="CREATE TABLE IF NOT EXISTS tabela (ID INTEGER PRIMARY KEY" +
                    ", tabelas TEXT)";
            Banco.execSQL(sql);

        }
        catch(Exception erro){
            Exibirmensagem("BANCO", "erro ao criar banco: =/"+ erro.getMessage(), "ok");
        }
    }

The "no intent" error is on this line:

tabelas[x]=retornadado();

If I comment on this line the Activity wheel.

I’m treating the array wrongly?

Answer 1

I believe you want to do this (probably the y needs to be initialized with 0, but I don’t know, you might be wanting to do something else that I didn’t realize):

public void geraLista() {
    cursor.moveToLast();
    int x = cursor.getCount();
    for(int y = 1; y < x; y++){
        //nextdado();   
        tabelas.Add(retornadado());   
        dadoanterior();
    };
    return tabelas;
}

I put in the Github for future reference.

But there’s an extra detail, you won’t be able to use one array (that has fixed size, can not add new elements), will have to use a ArrayList, the declaration should be:

ArrayList<String> tabelas;

And you obviously need to adapt where you need to. There’s even a way to continue array but it would be wrong for the intent of this code and I won’t even talk about.

Needing to convert again to array can do the following:

String[] array = tabelas.toArray(new String[tabelas.size()]);

This is a little weird, usually there are other, probably more reliable, ways to take all the data and add in this array. But the problem you’re pointing at should be solved like this.