Sign up for Spring Boot

Question

Good afternoon, you guys. I’m having difficulties to implement my Register on Spring Boot. I’m willing to do the method in three ways(if,else if,else) that if it is all right to register, that if anyone already exists with that email then from "Existing" and any error is "Invalid". But it is not working, the method I did to see if there is already in the bank the Person I am registering this correct? Someone can help me as I post and if the code is right or if there is some way to improve. Thank you.

---

Repository.

String findByEmail(String email)

------
Controller.

@PostMapping  
public ResponseEntity<Pessoa> cadastrar(@RequestBody Pessoa p) {  
        if(p.getEmail() == repository.findByEmail(p.getEmail())){    
            return ResponseEntity.status(400).build();  
        }else if(p != null) {  
            return ResponseEntity.ok().body(repository.save(p));
        }else {  
            return ResponseEntity.badRequest().build();  
        }    
    }

Answer 1

Hi,

I would not put this logic of existing or new registration in the same service (Rest) I think the controller should have a method to register new (POST) and a method to update an existing (PUT), even to take advantage of semantics (meaning of HTTP methods, PUT = update, POST = insert, DELETE = remove, etc)

Would something like this

@RequestMapping(value = "", method = RequestMethod.POST)
public ResponseEntity<?> cadastrar(@RequestBody Pessoa p) {
    try {
        Pessoa novaPessoa = service.save(p);
        return ResponseEntity.created(new URI("/pessoas/" + novaPessoa.getId())).build();
    } catch (Exception e) {
        throw new ResponseStatusException(HttpStatus.BAD_REQUEST,
                "Ocorreu um erro ao tentar salvar uma essoa", e);
    }
}

@RequestMapping(value = "/{id}", method = RequestMethod.PUT)
public ResponseEntity<?> atualizar(@RequestBody Pessoa p, @PathVariable("id") Integer id) {
    try {
        p.setId(id);
        service.save(p);
        return ResponseEntity.noContent().build();
    } catch (Exception e) {
        throw new ResponseStatusException(HttpStatus..BAD_REQUEST,
                "Ocorreu um erro ao tentar atualizar os dados da pessoa de id " + id, e);
    }
}   

And to test your API

POST /pessoas - adiciona uma pessoa
PUT /pessoas/{1} - atualiza os dados da pessoa de id 1