Not all paths return value

Question

The event Cadastrar is appearing with the error.

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using CamadaModelo;
using System.Configuration;
using System.Data;
using System.Data.OleDb;
using CamadaControle;

namespace CamadaControle
    {
    public class ctlTarefas
    {
        public bool Cadastrar(mdlTarefas _mdlTarefas)
        {
            try
            {
                string conexaoMSAccess = ConfigurationManager.ConnectionStrings["conexaoMSAccess"].ToString();
                OleDbConnection conexaodb = new OleDbConnection(conexaoMSAccess);
                conexaodb.Open();

                string query = "INSERT INTO tbl_tarefas (nome, descrição, data) VALUES (@Nome, @Descrição, @Data)";
                OleDbCommand cmd = new OleDbCommand(query, conexaodb);

                var pmtNome = cmd.CreateParameter();
                pmtNome.ParameterName = "@Nome";
                pmtNome.DbType = DbType.String;
                pmtNome.Value = _mdlTarefas.nome;
                cmd.Parameters.Add(pmtNome);

                var pmtDescricao = cmd.CreateParameter();
                pmtDescricao.ParameterName = "@Descrição";
                pmtDescricao.DbType = DbType.String;
                pmtDescricao.Value = _mdlTarefas.nome;
                cmd.Parameters.Add(pmtDescricao);

                var pmtData = cmd.CreateParameter();
                pmtData.ParameterName = "@Data";
                pmtData.DbType = DbType.String;
                pmtData.Value = _mdlTarefas.nome;
                cmd.Parameters.Add(pmtData);

                if(cmd.ExecuteNonQuery() > 0)
                {
                    conexaodb.Close();
                    return true;
                }
                else
                {
                    conexaodb.Close();
                    return false;
                }
            }

            catch(Exception ex)
            {
                Console.WriteLine("Erro ao inserir informações!" + ex.Message);
            }
            finally
            {
                Console.WriteLine("Precione inicio");
                Console.ReadKey();
            }
        }
    }
}

Answer 1

First, remove that try-catch of the code, it’s not doing anything useful, so it’s best to remove it, just put a catch if you can recover from the error or do something useful.

Afterward use the using to manage a resource, thus makes the closure of the resource in the correct way, this is wrong. See more. And another question is about the Method to execute when destroying class instance.

And simplify the code, I won’t talk about everything, but the whole if may be replaced by

return cmd.ExecuteNonQuery() > 0;

I put in the Github for future reference.

Nothing else.