Use of async with . NET Core and nhibernate

Question

No. NET Core I know we have the async and await for request async.

So far so good, but many frameworks in the market are creating methods with the signature MetodoAsync() and has the method without being async Metodo().

We can use async thus

[HttpGet]
public async Task<JsonResult> Get()
{
    return await Task.Run(() => Json(_fachadaGrupo.BuscarTodos()));
}

Remembering that in internal methods _fachadaGrupo.BuscarTodos(). there is no method async it uses a connection to nhibernate database and it does not have the method Async() at the moment. Soon then wanted to know if this still has the same efficiency and the same logic happens internally in which the thread and released for new requests. Or is it the same as not having.

 // facade
    public IEnumerable<GrupoDto> BuscarTodos()
    {
        return _buscarTodos.Buscar();
    }


    // Serviço
    public IEnumerable<GrupoDto> Buscar()
            {
                IRepositorioGrupo repositorioGrupo = new RepositorioGrupo(_nHibernateHelper);

                return repositorioGrupo.Lista(_usuario);
            }

// repositorio 
public IEnumerable<GrupoDto> Lista(Usuario usuario)
        {
            Usuario usuarioAlias = null;
            Grupo grupo = null;
            GrupoDto grupoDto = null;

            return Sessao.QueryOver(() => grupo).JoinAlias(() => grupo.Usuario, () => usuarioAlias)
                .SelectList(list => list.Select(() => grupo.Id).WithAlias(() => grupoDto.Id)
                .Select(() => grupo.Descricao).WithAlias(() => grupoDto.Descricao))
                .TransformUsing(Transformers.AliasToBean<GrupoDto>())
                .Where(g => g.Usuario == usuario).OrderBy(g => g.Id).Desc.List<GrupoDto>();
        }

Answer 1

The method BuscarTodos() obviously will never execute asynchronously. Your Get() will perform so when called with a await, unless it is modified. Since it is very simple and only calls another synchronous method, there will be no gain. The gain would be only in this method, among its own code that is almost indivisible.

The asynchronicity you want has to be performed within the BuscarTodos(), more precisely in this connection with the database. His real utility will probably be to have an asynchronous method that makes access to the external resource within him and it seems to me that Nhibernate should provide, but then I start to get into the speculation, I have not seen the code.

With the edition you can see that it is inside the Lista()that "magic" should happen, it is there in LINQ that should be asynchronous to obtain gains.

I was going to write the same as Tobias Mesquita, but I avoided because EF Core is not yet 100% ready, even in 2.0, but I would change ORM, even so I consider it better. I like the courage of those who recognize that an architecture is wrong and starts from scratch like Microsoft did. It would be great if Nhibernate did the same. He has no isolated problems. These products were created when you didn’t know everything you needed about Orms, the more modern ones are far more advantageous for having learned lessons.