My SQL always adds 24 click to each access instead of 1

Question

I have a script that counts the visits on my web pages and stores mysql, however, it is adding 24 clicks to each access, instead of 1.

What’s wrong with this code?

Look at the script:

<?php
$idcategoria = 19;
     if (!empty($idcategoria)){
         $guiacomercial_cliques=mysqli_query($con,"Select cliques FROM 
         cliquesguia WHERE categoria =".$idcategoria);
         if (mysqli_num_rows($guiacomercial_cliques) > 0){
              $painel=mysqli_query($con,"UPDATE cliquesguia SET cliques = 
              (cliques + 1) where categoria =".$idcategoria);
         }else{
            $painel=mysqli_query($con,"INSERT INTO cliquesguia (categoria, 
            cliques) VALUES (".$idcategoria.", '1')");
         }
     }
?>

Answer 1

Just try it, without the while:

<?php
     if (!empty($idcategoria)){
         $guiacomercial_cliques=mysqli_query($con,"Select cliques FROM 
         cliquesgc WHERE categoria =".$idcategoria);
         if (mysqli_num_rows($guiacomercial_cliques) > 0){
              $painel=mysqli_query($con,"UPDATE cliquesgc SET cliques = 
              (cliques + 1) where categoria =".$idcategoria);
         }else{
            $painel=mysqli_query($con,"INSERT INTO cliquesgc (categoria, 
            cliques) VALUES (".$idcategoria.", '1')");
         }
     }
?>

Remarks if $idcategoria is an integer, there is no need to use quotes. They are only used for string (text).

I could still get better with the clause ON DUPLICATED KEY UPDATE leaving much lighter and lean code. I’ll leave an example of how it works below:

If category is the Primary key (PK) of your table could do just that:

<?php
     if (!empty($idcategoria)){
            $painel=mysqli_query($con,"INSERT INTO cliquesgc (categoria, 
            cliques) VALUES (".$idcategoria.", '1') ON DUPLICATE KEY UPDATE 
            cliques=(cliques+1);");
     }
?> 

Translate, insert into the table cliquesgc if there is no category informed (which must be the primary key), otherwise if the category already exists (Key for duplicate) some +1 to the click field.