Duplicate records in the database table

Question

I have the following model:

function validarQuestionario()
{

    if(is_array($this->input->post('resposta[]')) || is_object($this->input->post('resposta[]')))
    {
        foreach ($this->input->post('resposta[]') as $single_resp) 
        {

            foreach ($this->input->post('idMarcacao[]') as $single_id)
            {
                $data['respostaAluno'] = $single_resp;
                $data['idMarcacao'] = $single_id;
                $this->db->insert('tbdquestionario', $data);
            }

        }
    }


}

Instead of being recorded 10 lines that would be the correct value, is being logged 100 lines in the bank.

Answer 1

I don’t use Codeigniter to have full authority over what I will talk about, but I will start from basic PHP analysis:

whereas $this->input->post('resposta[]') return a array with the values in the field resposta[], that $this->input->post('idMarcacao[]') also return a array with the values in the field idMarcacao[] and that both arrays are the same size (I won’t worry about validating this), you can do:

$respostas = $this->input->post('resposta[]');
$ids = $this->input->post('idMarcacao[]');

$data = array_map(function ($resposta, $id) {
  return compact('resposta', 'id');
}, $respostas, $ids);

$this->db->insert_batch('tbdquestionario', $data);

And only. Supposing that the array of answers be something like ['a', 'c'] and the array of ids [1, 2], the function array_map will generate a array in format:

$data = array (
  0 =>
  array (
    'resposta' => 'a',
    'id' => 1,
  ),
  1 =>
  array (
    'resposta' => 'c',
    'id' => 2,
  ),
);

And, as the documentation, the method insert_batch may receive a array of arrays to insert them at once (it is not feasible to do one by one), unless you want to manage the transactions independently.

Homework: why a function that inserts into the database is called validarQuestionario?