How to return the values of a List<> in C#

Question

I have a class Funcionario which has as attributes: CPF, Nome and Salario.

I have to create an X amount of instances of this class in a List<> and after that, return to the user the values of this list. With the code I created I did not get the values of the properties of each instance, only the namespace and the class.

aumento_funcionario.funcionario

I’d like to know why. Follow my code.

//Código da classe Program.cs
using System;
using System.Collections.Generic;
using System.Globalization;

namespace aumento_funcionarios
{
    class Program
    {
        static void Main(string[] args)
        {
            Console.Write("Quantos funcionários serão cadastrados? ");
            int qtde_cadastros = int.Parse(Console.ReadLine());

            List<funcionario> Lista = new List<funcionario>();

            for (int i = 0; i < qtde_cadastros; i++)
            {
                Console.WriteLine("Dados do " + (i + 1) + "º funcionário: ");
                Console.Write("CPF: ");
                int cpf = int.Parse(Console.ReadLine());
                Console.Write("Nome: ");
                string nome = Console.ReadLine();
                Console.Write("Salário: ");
                double salario = double.Parse(Console.ReadLine());
                Lista.Add(new funcionario(cpf, nome, salario));
                Console.WriteLine();
            }

            for (int i = 0; i < Lista.Count; i++)
            {
                Console.WriteLine(Lista[i]);
            }

            Console.ReadLine();
        }
    }
}




//Código classe Funcionarios
    using System;
    using System.Collections.Generic;
    using System.Globalization;

    namespace aumento_funcionarios
    {
        class funcionario
        {
            public int CPF;
            public string Nome;
            public double Salario { get; private set; }

            public funcionario (int cpf, string nome, double salario)
            {
                this.CPF = cpf;
                this.Nome = nome;
                this.Salario = salario;
            }

        }
    }

Answer 1

There are several problems in the code, some just of style. The biggest is that you are trying to convert something that is not guaranteed to be converted and this will break the application if the typing is wrong. The right is to check before using. I just closed the application to simplify, but you can send an error message and ask again for typing until a valid value is entered. In real code people create codes that do this on each item and put in function for easy use.

Note that I changed several things in the code, such as how to print, the names of things, and the use of foreach in place of for. It should be the preference, until only the for resolve. I used names inside the C nomenclature standard#.

If you used a property in a class field, why not use it at all? Or why not use the field at all if you used two of them? Keep a pattern. Including maintaining the right uppercase and lowercase pattern, which I made wrong.

You were having the list printed up. She doesn’t have an automatic printing medium that comes out as you imagine. There are endless ways to print a list, you have to assemble that item by item. And even within the item also has many ways to print each member of the list item, so you have to deal with it. Even the list was picking up every item, but not every member.

using static System.Console;
using System.Collections.Generic;

public class Program {
    public static void Main() {
        Write("Quantos funcionários serão cadastrados? ");
        if (!int.TryParse(ReadLine(), out var quantidade)) return;
        var lista = new List<Funcionario>();
        for (int i = 0; i < quantidade; i++) {
            WriteLine($"Dados do {(i + 1)}º funcionário: ");
            Write("CPF: ");
            if (!int.TryParse(ReadLine(), out var cpf)) return;
            Write("Nome: ");
            var nome = ReadLine();
            Write("Salário: ");
            if (!double.TryParse(ReadLine(), out var salario)) return;
            lista.Add(new Funcionario(cpf, nome, salario));
            WriteLine();
        }
        foreach (var item in lista) WriteLine($"CPF: {item.Cpf} - Nome: {item.Nome} - Salário: {item.Salario}");
    }
}

public class Funcionario {
    public int Cpf;
    public string Nome;
    public double Salario { get; private set; }
    public Funcionario (int cpf, string nome, double salario) {
        Cpf = cpf;
        Nome = nome;
        Salario = salario;
    }
}

Behold working in the ideone. And in the .NET Fiddle. Also put on the Github for future reference.

Answer 2

What happens is that when you ask to write the employee list on the console and since employees are not a simple type, but a composite object, the compiler can’t print it the way you want, I made a modification in your code so that the printing will work, then, following the logic, you can modify it as is best for you. Follows the code:

public static void Main()
{
    Console.Write("Quantos funcionários serão cadastrados? ");
        int qtde_cadastros = int.Parse(Console.ReadLine());

        List<funcionario> Lista = new List<funcionario>();

        for (int i = 0; i < qtde_cadastros; i++)
        {
            Console.WriteLine("Dados do " + (i + 1) + "º funcionário: ");
            Console.Write("CPF: ");
            int cpf = int.Parse(Console.ReadLine());
            Console.Write("Nome: ");
            string nome = Console.ReadLine();
            Console.Write("Salário: ");
            double salario = double.Parse(Console.ReadLine());
            Lista.Add(new funcionario(cpf, nome, salario));
            Console.WriteLine();
        }

        for (int i = 0; i < Lista.Count; i++)
        {
            Console.WriteLine(Lista[i]);
        }

        Console.ReadLine();
}

class funcionario
    {
        public int CPF;
        public string Nome;
        public double Salario { get; private set; }

        public funcionario (int cpf, string nome, double salario)
        {
            this.CPF = cpf;
            this.Nome = nome;
            this.Salario = salario;
        }
        public override string ToString()
        {
            return "funcionario: " + this.CPF + " " + this.Nome + " " +this.Salario + "\n";
        }
    }

}

What I did was overwrite the method of writing the employee object so that when called prints the attributes. I hope I’ve helped

Answer 3

Since the list is not of a simple type, like string, int and etc...it is necessary to print all attributes of the list.

In case it would look like this:

 for (int i = 0; i < Lista.Count; i++)
 {
      Console.WriteLine(Lista[i].Cpf);
      Console.WriteLine(Lista[i].Nome);
      Console.WriteLine(Lista[i].Salario );
 }

Answer 4

As already mentioned, you must display each property of your object Funcionario of the list.

You can use the method ForEach to display, ends up being simpler.

Lista.ForEach(funcionario =>
        {
            Console.WriteLine(funcionario.Cpf);
            Console.WriteLine(funcionario.Nome);
            Console.WriteLine(funcionario.Salario);
        });