Null Object Reference JAVA

Question

The whole problem is happening in a search, when I click and start typing the field it goes filtering the results, when I click on one of these results to open another screen, this error:

Attempt to invoke virtual method 'void android.widget.Textview.setText(java.lang.Charsequence)' on a null Object Reference

The search code looks like this:

@Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
    inflater.inflate(R.menu.menu_restaurante, menu);

    MenuItem searchItem = menu.findItem(R.id.action_search);

    SearchManager searchManager = (SearchManager) getActivity()
            .getSystemService(Context.SEARCH_SERVICE);

    searchView = null;
    if (searchItem != null) {
        searchView = (SearchView) searchItem.getActionView();

        if(restaurantes == null || restaurantes.size() == 0){
            searchView.setEnabled(false);
        }
    }

    if (searchView != null) {
        searchView.setSearchableInfo(searchManager
                .getSearchableInfo(getActivity().getComponentName()));

        searchView.setOnQueryTextListener(new OnQueryTextListener() {

            @Override
            public boolean onQueryTextSubmit(String arg0) {
                return false;
            }

            @Override
            public boolean onQueryTextChange(String arg0) {
                filtrarRestaurante(arg0);
                return false;
            }
        });
    }
    //searchView.setVisibility(View.INVISIBLE);
    super.onCreateOptionsMenu(menu, inflater);
}

The function filtarRestaurante(agr0) is this:

public void filtrarRestaurante(String filtro){
 ArrayList<Restaurante> restaurantesEncontrados = new ArrayList<Restaurante>();

    if(filtro.length() == 0 && restaurantes != null){
        restaurantes.clear();
        restaurantes.addAll(restaurantesBkp);
        configurarAdapter();
        return;
    }

    // Procura pelo restaurante
    restaurantes.clear();
    restaurantes.addAll(restaurantesBkp);
    for(Restaurante restaurante : restaurantes){
        if(restaurante.getNomeRestaurante().toLowerCase().contains(filtro.toLowerCase())){
            restaurantesEncontrados.add(restaurante);
        }
    }
    restaurantes = restaurantesEncontrados;
    configurarAdapter();
}

Here is the init of my Fragment:

    @AfterViews
public void init() {
    Globales.setPedido(new Pedido());

    restaurante = (Restaurante) getArguments().getSerializable(RESTAURANTE_CARDAPIO);
    Globales.setRestauranteAtual(restaurante);
    carregarCardapio(restaurante);
}

So I charge the restaurant:

Restaurante restaurante;

This error is happening when I click on the restaurant and the error happens here:

@Override
public void onResume() {
    super.onResume();
    try{
        updateCarrinho();
        Globales.setListaOpcionais(null);

        TextView toolbarTitle = (TextView) getActivity().findViewById(
                R.id.toolbar_title);
        toolbarTitle.setText(restaurante.getNomeRestaurante());
    }catch (Exception e){
        MessageUtil.showError(getActivity(), e.getMessage());
    }

}

Right on this line

toolbarTitle.setText(restaurant.getNomeRestaurant());

when I’m going to name the restaurant the exception, why would I give it ?

• I’ve noticed that restaurants sometimes double in search results.

• The cool thing is that this only happens when I search the name of the restaurant, otherwise it comes in normally, so if I search it and I go back to the problem.

  ATTACHMENTS:

Photo of the debug in the restaurant part = (Restaurant) getArguments(). getSerializable(RESTAURANTE_CARDAPIO);

Answer 1

Renan,

The problem is here:

TextView toolbarTitle = (TextView) getActivity().findViewById(R.id.toolbar_title);

When you call the getActivity(), You’re telling him to go look in the Activity layout that called his Fragment.

When you declare the Fragment layout, you call there on onCreateView so, for example:

View view = inflater.inflate(R.layout.fragment, container, false);

That one view that you should call to reference a layout item, in your case it would look like this:

TextView toolbarTitle = (TextView) view.findViewById(R.id.toolbar_title);

Answer 2

The error is because the findViewById() of this line:

TextView toolbarTitle = (TextView) getActivity().findViewById(R.id.toolbar_title);

is returning null, IE, did not find a view with that id and with that the app crashea because you are trying to set the text in something that does not exist.

Since you didn’t post the code I will give some kicks, since it appears to be running inside a Fragment (by getActivity you are calling):

• If your Textview with the "toolbar_title" attribute is in the Activity layout, make sure that in the Activity layout the name is matching.

• If your Textview with the "toolbar_title" attribute is in the Fragment layout, make sure that in the Fragment layout the name is matching, create a global variable in Fragment and use findViewById() in Fragment’s Oncreateview() method.

Example:

private TextView mToolBarTitle;

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
                         Bundle savedInstanceState) {
    View rootView = inflater.inflate(R.layout.fragment_article_detail, container, false);
    mToolbarTitle = (TextView) rootView.findViewById(R.id.toolbar_title);

    ...

    return rootView;
}

Finally, seven text using this global variable in your method:

try{
    updateCarrinho();
    Globales.setListaOpcionais(null);

    mToolbarTitle.setText(restaurante.getNomeRestaurante());
}catch (Exception e){
    MessageUtil.showError(getActivity(), e.getMessage());
}