Similar function to indexof() in Javascript

Question

Similar function to indexof() in Javascript

Asked 7 years, 8 months ago

Viewed 196 times

0

Supposing I have a string:

Lorem ipsum dolor sit Amet, consectetur adipiscing Elit. Praesent eget leo consectetur, condimentum est eu, convallis dolor. Aliquam fringilla et odio a congue. Phasellus accumsan, velit in elementum porttitor, massa mi tristique velit, non molestie tellus nisl et odio. Sed id Orci mollis ex egestas semper. Cras diam Purus, Viverra a Arcu non, placerat suscipit sapien. Sed suscipit tincidunt urna, in accumsan lacus suscipit a. Suspendisse ut imperdiet urna, a ultricies ex. Vivamus eu pellentesque risus, vitae suscipit odio. Nam enim leo, auctor nec molestie non, gravida felis..."

And you want to scan this string using an array of strings to know what "matchs" you find in it, how can I do it in a more performative way than using the

indexOf()

follows example of my code:

var strErro = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent eget leo consectetur, condimentum est eu, convallis dolor. Aliquam fringilla et odio a congue. Phasellus accumsan, velit in elementum porttitor, massa mi tristique velit, non molestie tellus nisl et odio. Sed id orci mollis ex egestas semper. Cras diam purus, viverra a arcu non, placerat suscipit sapien. Sed suscipit tincidunt urna, in accumsan lacus suscipit a. Suspendisse ut imperdiet urna, a ultricies ex. Vivamus eu pellentesque risus, vitae suscipit odio. Nam enim leo, auctor nec molestie non, gravida vel felis. In pharetra dolor urna, at mattis lectus finibus in. Praesent sed facilisis diam. Pellentesque ornare luctus placerat. Aenean nisl augue, hendrerit ac metus id, fringilla tempor eros. Aliquam erat volutpat. Quisque feugiat, augue vitae cursus scelerisque, libero sem pellentesque neque, non vehicula urna urna vel justo. Curabitur fringilla finibus fringilla. Curabitur fermentum eros vel massa hendrerit euismod. Curabitur scelerisque ipsum a est egestas, accumsan elementum augue interdum. Duis ex turpis, placerat non tincidunt tincidunt, viverra at lorem. Proin sapien nisi, semper in velit quis, egestas placerat eros. Pellentesque non felis auctor massa rhoncus auctor. Aenean feugiat suscipit ex, eu porttitor neque vestibulum nec. Donec sollicitudin euismod vestibulum. Proin varius, ex ac dignissim cursus, enim ex convallis quam, vel porta ante nisl tempor dui. Pellentesque vel facilisis velit, eget pharetra velit. Nulla fermentum vel turpis vel rutrum. Interdum et malesuada fames ac ante ipsum primis in faucibus. Integer mattis metus auctor, volutpat justo sed, porta ante. Donec tincidunt rhoncus urna non finibus. Pellentesque ut venenatis nisi. Praesent bibendum est id sapien consequat, a molestie tellus sollicitudin. Donec nec ligula at est lacinia finibus ac id diam. Praesent efficitur diam eu diam porttitor, quis ullamcorper justo consectetur. Suspendisse lectus enim, ornare venenatis ipsum ac, efficitur sollicitudin enim. Sed at enim tempus, vestibulum arcu et, scelerisque dui. Etiam eu malesuada eros, nec rutrum justo. Cras a odio maximus, tristique nisl at, ullamcorper nibh. Nunc quis interdum magna. Ut et eros ac ligula tristique sodales et iaculis justo. Sed aliquet nulla vitae leo scelerisque, non lacinia odio efficitur. Aliquam mauris magna, dictum nec mauris et, congue viverra ligula. Aliquam vestibulum ligula in augue venenatis viverra. Pellentesque in urna at nulla placerat consectetur a eu arcu. Fusce augue mauris, suscipit vel libero eu, vulputate iaculis nunc. Aenean condimentum neque quis urna egestas, ut feugiat ex efficitur. Morbi vitae ante erat. Fusce pretium quam vel purus maximus, ut rutrum mi volutpat. Cras pellentesque aliquam justo, ut maximus lorem consectetur sit amet. Sed nec leo sed magna scelerisque euismod at eget urna.";


var erros = "";
var found = false;
var ini;
var erro = ["erro1", "erro2", "erro3", "tempor"];

for (var i=0; i<erro.length;i++){

    ini = strErro.indexOf(erro[i]);   

    if (ini!=-1 && found){
        erros+= erro[i]+" ";
    } else if (ini!=-1) {
        erros+= erro[i]+" ";
        found=true;
    }

}

if (!found) {
    strErro;
} else {
    erros;
}

@Rafael Acioly Thanks for helping keep the post more organized and clean!

– Tiaurls

2017/04/12 at 16:25
And what’s the problem? The function indexOf no longer solves your case?

– Woss

2017/04/12 at 16:30
@Andersoncarloswoss I would like to know if there is any more performative way.

– Tiaurls

2017/04/12 at 16:33
2

In this reply there are 6 ways to do and a test of which it concludes that the indexOf is the fastest way (for this situation).

– Woss

2017/04/12 at 16:36
@Andersoncarloswoss In my test the "regex"* was the most performative, but I believe the gain is not so great.

– Tiaurls

2017/04/12 at 16:51
2

http://jsben.ch/#/xm2BV In most tests, indexes end up being faster than traditional loops

– MarceloBoni

2017/04/12 at 17:05

Show 1 more comment

4 answers

4

And you want to scan this string using an array of strings to know what "matchs" you find in it, how can I do it in a more performative way than using the index()

In case the indexOf this good the way this, the only thing I would do to improve (it’s just micro-optimization) would be to save the total value and reduce one of ifs:

for (var i = 0, j = erro.length, current; i < j; i++) {

    current = erro[i];

    if (strErro.indexOf(current) !== -1) {
        erros+= current+" ";
    }
}

found = erros !== ""; //Equivale ao true

Of course saving arrays values in a variable (current) and the total of .length is only significant if the var erro is giant. The 2 ifs part didn’t make much sense, because found=true will be executed only once

An addendum

If it’s to use the .some I believe that the regex is totally dispensable:

erro.some(function(current) {
    if (strErro.indexOf(current) !== -1) {
        erros += current;
    }
});

The var error contains approximately 90 Strings at the moment, but it grows daily.

– Tiaurls

2017/04/12 at 17:56
1

That’s what I imagine @Tiaurls, so I saved .length in j

– Guilherme Nascimento

2017/04/12 at 17:57

Browser other questions tagged javascript

You are not signed in. Login or sign up in order to post.

by MarceloBoni • **6,385** points · Answer 1 · 2017-04-12T17:45:26+00:00

5

Benchmark of the proposed functions, should more arise, I update.

Chrome Version 57.0.2987.133 (64-bit)

Firefox Version 51.0 (32-bit)

Opera Version 43.0.2442.1144 (64-bit)

3

The q shows q if you want performance even have to make different version for each browser. And monitor if remains true.

– Maniero

2017/04/12 at 17:50
1

The Firefox JS engine has internal optimization, the result of it is the only one that varies and is usually faster than other engines, but it is not all that it manages to "pre-optimize". This optimization usually occurs if you are in functions, now note the difference if you do so: http://jsben.ch/#/rKfMX

– Guilherme Nascimento

2017/04/12 at 17:55
Very good, great test! Interesting how the engine of each browser implements and processes different the same commands!

– Ricardo Pontual

2017/04/12 at 22:55

by Matheus • **1,783** points · Answer 2 · 2017-04-12T16:36:29+00:00

0

It’s okay to use the indexOf, but there is a way to make code cleaner using array map

var strErro = "teste teste teste";
var erros = "";
var erro = ["erro1", "erro2", "erro3", "tempor"];

erro.map(function(value){
   if(strErro.indexOf(value) > -1){
      erros+= value+" ";
   }
});

if (erros.length > 0) {   
    erros;
} else {
    strErro;
}

thanks, would you have some source for me to better understand how the map array works ?

– Tiaurls

2017/04/12 at 16:51
1

@Tiaurls Claro. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map

– Matheus

2017/04/12 at 16:57
4

Which makes the performance worse, which is the opposite of what you want.

– Maniero

2017/04/12 at 16:59
@Bigown Pq gets worse?

– Matheus

2017/04/12 at 17:11
Because it’s an abstraction, it creates an indirect. If performance is required, one should not adopt the functional style unless the language can optimize this, which is not the case with JS.

– Maniero

2017/04/12 at 17:14
@Matheus Thank you for the reference. When I circled the script here, apparently it got a little slower anyway, but I found interesting the concept that was presented to me from the map.

– Tiaurls

2017/04/12 at 17:41

Show 1 more comment

by Ricardo Pontual • **21,129** points · Answer 3 · 2017-04-12T17:01:00+00:00

Can also be done using array.some (more information here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some)

The method some will go through all the items in the array, so we can use the values as regular Expression to facilitate comparison:

var strErro = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent eget leo consectetur, condimentum est eu, convallis dolor. Aliquam fringilla et odio a congue. Phasellus accumsan, velit in elementum porttitor, massa mi tristique velit, non molestie tellus nisl et odio. Sed id orci mollis ex egestas semper. Cras diam purus, viverra a arcu non, placerat suscipit sapien. Sed suscipit tincidunt urna, in accumsan lacus suscipit a. Suspendisse ut imperdiet urna, a ultricies ex. Vivamus eu pellentesque risus, vitae suscipit odio. Nam enim leo, auctor nec molestie non, gravida vel felis. In pharetra dolor urna, at mattis lectus finibus in. Praesent sed facilisis diam. Pellentesque ornare luctus placerat. Aenean nisl augue, hendrerit ac metus id, fringilla tempor eros. Aliquam erat volutpat. Quisque feugiat, augue vitae cursus scelerisque, libero sem pellentesque neque, non vehicula urna urna vel justo. Curabitur fringilla finibus fringilla. Curabitur fermentum eros vel massa hendrerit euismod. Curabitur scelerisque ipsum a est egestas, accumsan elementum augue interdum. Duis ex turpis, placerat non tincidunt tincidunt, viverra at lorem. Proin sapien nisi, semper in velit quis, egestas placerat eros. Pellentesque non felis auctor massa rhoncus auctor. Aenean feugiat suscipit ex, eu porttitor neque vestibulum nec. Donec sollicitudin euismod vestibulum. Proin varius, ex ac dignissim cursus, enim ex convallis quam, vel porta ante nisl tempor dui. Pellentesque vel facilisis velit, eget pharetra velit. Nulla fermentum vel turpis vel rutrum. Interdum et malesuada fames ac ante ipsum primis in faucibus. Integer mattis metus auctor, volutpat justo sed, porta ante. Donec tincidunt rhoncus urna non finibus. Pellentesque ut venenatis nisi. Praesent bibendum est id sapien consequat, a molestie tellus sollicitudin. Donec nec ligula at est lacinia finibus ac id diam. Praesent efficitur diam eu diam porttitor, quis ullamcorper justo consectetur. Suspendisse lectus enim, ornare venenatis ipsum ac, efficitur sollicitudin enim. Sed at enim tempus, vestibulum arcu et, scelerisque dui. Etiam eu malesuada eros, nec rutrum justo. Cras a odio maximus, tristique nisl at, ullamcorper nibh. Nunc quis interdum magna. Ut et eros ac ligula tristique sodales et iaculis justo. Sed aliquet nulla vitae leo scelerisque, non lacinia odio efficitur. Aliquam mauris magna, dictum nec mauris et, congue viverra ligula. Aliquam vestibulum ligula in augue venenatis viverra. Pellentesque in urna at nulla placerat consectetur a eu arcu. Fusce augue mauris, suscipit vel libero eu, vulputate iaculis nunc. Aenean condimentum neque quis urna egestas, ut feugiat ex efficitur. Morbi vitae ante erat. Fusce pretium quam vel purus maximus, ut rutrum mi volutpat. Cras pellentesque aliquam justo, ut maximus lorem consectetur sit amet. Sed nec leo sed magna scelerisque euismod at eget urna.";

var erros="";
// usadas barras para deixar as strings prontas para serem comparadas com regex
var regexList = [/erro1/, /erro2/, /erro3/, /tempor/];
// verifica os itens do array    
var isMatch = regexList.some(function(rx) { 
  var test = rx.test(strErro);
  if (test) {
    erros += rx.toString().replace('/','').replace('/',' ');
  }
    return; 
});


console.log('erros=' + erros)

The method some performs very fast, and comparison with regex also.
Here you can see a bechmark comparing the use of for and some and compare performance: https://jsperf.com/array-some-vs-loop