I can’t go to another page with the header function

Question

I’m having trouble with the header(), I made a schedule to change the database data and when I click on the button to change it goes to a blank page then I put the header("Location: AdmAgenda.php"); so that you could return to the page already with updated data but is giving error:

The localhost page is not working

Excessive redirection by localhost Try to clear cookies.

What can I do to fix?

my code:

<?php 
$idSeg = filter_input(INPUT_GET, "id-segunda");
$seg = filter_input(INPUT_GET, "seg");

$idTerca = filter_input(INPUT_GET, "id-ter");
$tercaa = filter_input(INPUT_GET, "ter");


$idQuarta = filter_input(INPUT_GET, "id-quarta");
$quartaa = filter_input(INPUT_GET, "qua");


$idQuinta = filter_input(INPUT_GET, "id-quinta");
$quintaa = filter_input(INPUT_GET, "qui");

$idSexta = filter_input(INPUT_GET, "id-sexta");
$sextaa = filter_input(INPUT_GET, "sex");

$idSabado = filter_input(INPUT_GET, "id-sabado");
$sabadoo = filter_input(INPUT_GET, "sab");


include("conexao.php");


if($link) {
    $segg = mysqli_query($link, "UPDATE horas_segunda set horas_de_segunda='$seg' where id='$idSeg';");
    $terc = mysqli_query($link, "UPDATE horas_terca set horas_de_terca='$tercaa' where id='$idTerca';");
    $quarr = mysqli_query($link, "UPDATE horas_quarta set horas_de_quarta='$quartaa' where id='$idQuarta';");
    $quinn = mysqli_query($link, "UPDATE horas_quinta set horas_de_quinta='$quintaa' where id='$idQuinta';");
    $sexx = mysqli_query($link, "UPDATE horas_sexta set horas_de_sexta='$sextaa' where id='$idSexta';");
    $sabaa = mysqli_query($link, "UPDATE horas_sabado set horas_de_sabado='$sabadoo' where id='$idSabado';");
    header("Location: AdmAgenda.php");
}
else{
    die("Erro: " .mysqli_error($link));
}
?>

Answer 1

I don’t agree with the way you are doing things, because only redirecting will not give the "Update successfully performed" information to the user, but if you change:

if($link) {

for:

if($link && isset($_GET["seg"])) { 

already solves the problem the way you want.

Answer 2

Despite not being best practice, it’s okay to redirect to the same page as long as you know what you’re doing and can write your logic in a way that never falls into an infinite redirect (the browser actually cancels the loop when it finds that there are many redirects to the same page, launching something like ERR_TOO_MANY_REDIRECTS). So it is not enough to stop navigation.

In your specific problem, you are just checking whether the variable $link (that from the context, it is understood that it is an open connection with the mysql) is not null, that is to say: at all times (if all is well).

To avoid this, instead of checking if there is a connection, make sure the url is sending the parameters to save. I suggest putting above your if($link) { something like that:

if ( $idSeg && $seg && $idTerca && $tercaa && $idQuarta && $quartaa &&
     $idQuinta && $quintaa && $idSexta && $sextaa && $idSabado && $sabadoo ) {

    if($link) {
        /* funções de update */
        header("Location: AdmAgenda.php");
    } else{
        die("Erro: " .mysqli_error($link));
    }

}

This would imply only updating the database and redirecting if all these parameters are present (I don’t know if this is the logic of your application, but it is for explanation purposes only, you adapt). A more clean is check one by one. Done this, when you redirect, the parameters will not be sent and consequently will not fall into this if.