Program that sums/multiplies 2 numbers and what’s between them and prints

Question

I believe the logic of this programme is right, but the result is wrong.

Make a program that receives two X and Y numbers, being X < Y. Calculate and show:

• the sum of the even numbers in that range of numbers, including the numbers entered;
• the multiplication of the odd numbers in that range, including those typed

Code:

#include <stdio.h>

void main()
{
    int x = 0, y = 0, somaPares = 0, multiImpares = 0;

    scanf("%d", &x);
    scanf("%d", &y);

    somaPares = (x+y);
    multiImpares = (x*y);
    printf("%d\n", somaPares);
    printf("%d\n", multiImpares);

    while (x<y)
    {
        x++;
        if(x%2==0){
            somaPares = somaPares + x;
        }
        else {
            multiImpares = multiImpares*x;
        }
    }

    printf("A soma de X e Y mais os números pares entre eles é: %d\n", &somaPares);
    printf("A multiplicação de X e Y mais os números ímpares entre eles é: %d", &multiImpares);
}

The input I am putting is: 5 and 3, 8 being the sum and 15 the result, in the first two printfs is coming right now in the last two printfs is returning me respectively, 2752260 and 2752256.

Answer 1

Just pull the operator out & us printf() end. They are having the address of the variables printed and not their content printed. If you want the content, use the name of the simple variable. Maybe you got confused with the scanf() which requires the operator to pass by reference and the variable to receive the new value.

#include <stdio.h>

int main() {
    int x = 0, y = 0;
    scanf("%d", &x);
    scanf("%d", &y);
    int somaPares = x + y;
    int multiImpares = x * y;
    printf("%d\n", somaPares);
    printf("%d\n", multiImpares);
    while (x < y) {
        x++;
        if (x % 2 == 0) somaPares += x;
        else multiImpares *= x;
    }
    printf("A soma de X e Y mais os números pares entre eles é: %d\n", somaPares);
    printf("A multiplicação de X e Y mais os números ímpares entre eles é: %d", multiImpares);
}

Behold working in the ideone. And in the repl it.. Also put on the Github for future reference.

Maybe the algorithm is also wrong but then I can’t be sure. I answered what was asked and what is clear in the question.

Answer 2

The while can wrong.. And the & us printf With for :

#include <stdio.h>

main(void)
{
    int x = 0, y = 0, cont, pares = 0, impares = 1;
    while(x >= y)
    { // trate x como menor que y, como o pedido
        scanf("%d", &x);
            scanf("%d", &y);
    }

    printf("Soma = %i\n", (x + y));
    printf("Produto = %i\n", (x * y));

    for(cont = x; cont <= y; cont ++)
    {
        if(cont % 2 == 0)
            pares += cont;
        else
            impares *= cont;
    }
    printf("Resultado:\n");
    printf("Pares = %i\n", pares);
    printf("Impares = %i\n", impares);
}

Behold him spinning with values 3 for x and 9 for y because x must be less than y.