Divisors of a number which variable to print

Question

I came across a problem with the splitters of a number and that also goes to other problems

I made this code to print me number dividers from largest to smallest, but it is just printing one of the dividers. How can I solve this?

import java.util.Scanner;

public class ex1dd {

    public static void main(String[] args) {
        Scanner sc=new Scanner(System.in);

        int x=0;
        int y=0;

        System.out.println("Dá-me 2 números");
        x= sc.nextInt();
        y=sc.nextInt();



        for (int i =x;i<=y;i++) {
            if (i %y == 0){
                System.out.println(i);
            }

        }
    }
}

Answer 1

From what you can understand, you want to print the divisors of a number x between x and another number y. The error happens because of the line:

if (i %y == 0)

Under this condition, the y only, which, in the context of the programme, will be y. To correct, replace the line with:

if (i % x == 0)

The whole code goes like this:

import java.util.Scanner;

public class Main {
  public static void main(String[] args) {
        Scanner sc=new Scanner(System.in);

        int x=0;
        int y=0;

        System.out.println("Dá-me 2 números");
        x= sc.nextInt();
        y=sc.nextInt();



        for (int i =x;i<=y;i++) {
            if (i % x == 0){
                System.out.println(i);
            }

        }
    }
  }

A tip to optimize the code: knowing that a number is always splitter of itself, you can print, before the loop for, the number x eliminating a comparison.

See working on repl.it