How to clear form fields in c#?

Question

I’m doing a project for college, I created a GroupBox and inside there’s RadioButton, Label, MaskedTexbox and TextBox. When I click the cancel button I did the cleaning of the MaskTexbox and TextBox and disable the Textbox. It just cleans and had to repeat the code to clean follows below.

private void toolStripButtonCancelar_Click(object sender, EventArgs e)
{
    rdbAprovadoAberto.Enabled = false;
    rdbReprovadoAberto.Enabled = false;
    lblNomeUser.Text = "Sistema";

    maskDataAprovReprov.Text = "";// limpa o campo MaskedTextBox
    txtMotivoReprovaAberto.Text = "";// limpa o campo TextBox
    this.txtMotivoReprovaAberto.Enabled = false;

    // tenho que duplicar o código senão não limpa os campos e desabilita txtMotivoReprovaAberto

    rdbAbertoAberto.Checked = true;
    maskDataAprovReprov.Text = "";
    txtMotivoReprovaAberto.Text = "";
    txtMotivoReprovaAberto.Enabled = false;
}

and that also worked out but I don’t know if it’s good practices

private void toolStripButtonCancelar_Click(object sender, EventArgs e)
{   
    rdbAprovadoAberto.Enabled = false;
    rdbReprovadoAberto.Enabled = false;
    lblNomeUser.Text = "Sistema";

    if (rdbAprovadoAberto.Checked)
    {
        maskDataAprovReprov.Text = "";
    }

    if (rdbReprovadoAberto.Checked)
    {
        maskDataAprovReprov.Text = "";
        txtMotivoReprovaAberto.Text = "";
        txtMotivoReprovaAberto.Enabled = false;
    }
}

Answer 1

I like to make a generic method. For example, in the following code I clean all the text boxes of a FORM. You can put other conditions to check other types of components of the FORM and do what you wish.

foreach (Control c in this.Controls)
{
    if (c.GetType().ToString() == "System.Windows.Form.Textbox")
    {
        c.Text = "";
    }
}

Answer 2

Break your code more, for easy reading. The smaller the code the easier it is to understand and debug.

Then you can slowly improve. is improve to view duplicate code or code (in this case the functions) with more than one responsibility.

Many conditions in the same function can make your code barely readable and difficult to maintain.

Answer 3

I usually create a cleaning method only. There are how to make generic methods, for all controls, but I do one for each situation, will your preference.

Avoid using TextBox1.Text = ""; instead prefer to use: TextBox1.Text = string.Empty; besides getting more elegant, avoids you unintentionally pressing the space bar between the quotes and theMela all your code.

Create methods just for this, do not clear on the click of the cancel button as you did, instead call the cleaning method only.

Answer 4

Utilize TextBox1.Text = string.Empty;

if there are several do so:

 public void limpaCampos()
 {
   TextBox1.Text  = 
   TextBox2.Text  = 
   TextBox3.Text  = 
   TextBoxn.Text  = string.Empty;
 }