Too Many values to unpack (expected 2) no Django

Question

I have this piece of code in Django, the intention is to insert, if there is already the ds_user_id then it updates the user with this ds_user_id instead of creating a new

ds_user_id = int(post_login['ds_user_id'])
csrftoken = post_login['csrftoken']
cookies = json.dumps(str(post_login['cookies']))

defaults = {
  'username': username,
  'password': password,
  'ds_user_id': ds_user_id,
  'csrftoken': csrftoken,
  'cookies': cookies,
  'status': 0
}

try:
  obj = User.objects.get(ds_user_id=ds_user_id)

  for key, value in defaults.keys():
    setattr(obj, key, value)
  obj.save()
except User.DoesNotExist:
  new_values = {
    'username': username,
    'password': password,
    'ds_user_id': ds_user_id,
    'csrftoken': csrftoken,
    'cookies': cookies,
    'status': 0
  }

  new_values.update(defaults)

  obj = User(**new_values)
  obj.save()

The insert worked however, when trying to log in again, I get:

Too Many values to unpack (expected 2)

I’m not getting it very well, but I think it’s this line that’s bugling my code:

for key, value in defaults.keys():

Answer 1

You used the method dict.keys, that returns an eternal object with only dictionary keys and error occurs by deconstructing tuple of a value into two variables.

for key, value in defaults.keys():
    setattr(obj, key, value)

As your intention is to get the key/value pair, use dict.items:

for key, value in defaults.items():
    setattr(obj, key, value)