Check items from a list in another list

Question

I’m having trouble making a method to check two lists. This method will receive a list which is the list that has been added to the order and the Purchase Order Id to which that order has been associated. The method calls another method that returns from the database the list of items in the purchase request. So, at this point I have 2 lists: one received as a parameter with the items being added to the request, and the other I searched in the database with the items of the request.

I need to check if the items that are in the request are in the request, IE, check that the items in the list I received as parameter are in the items in the list that came from the bank. If so, I need to check if this item has already been purchased (I have a Boolean property for this), and if it has not been purchased I need to mark this property as true and let this item pass to be registered.

I also need to check that these lists have no item that was not requested in the purchase request, IE, the buyer can not buy without a requisition for this item.

All items that should not be in the order, either because it was already purchased or because it was not requested, must be removed by the system. After registering the request, I have to display the list of items that were removed by the system.

I know it’s gotten really big because it’s a complex process but if anyone can help me with it, I’ve tried it all day today, but it’s always a loophole.

Code of the Method

public ControlePedidoRCM ControlePedidoRCM(int IdRCM, List<MaterialPedido> IdMaterial)
        {
            RCMDal rd = new RCMDal();
            ControlePedidoRCM Controle = new ViewModel.ControlePedidoRCM();
            List<int> Comprados = new List<int>();
            List<int> Fora = new List<int>();

            List<MaterialRCM> itens = rd.ListarItens(IdRCM).ToList();

            foreach(var item in itens)
            {
                for(int i = 0; i < IdMaterial.Count; i++)
                {
                    //se o material estiver na lista de RCM
                    if(item.MaterialID == IdMaterial[i].MaterialID)
                    {
                        if(item.Comprado == true)
                        {
                            //ja foi comprado
                            Comprados.Add(item.MaterialID);
                        }
                    }
                    else
                    {
                        //não está na RCM
                        Fora.Add(item.MaterialID);
                    }
                }
            }
            Controle.Comprado = Comprados;
            Controle.Fora = Fora;
            return Controle;
        }

Answer 1

Alan,

It’s easier for other developers to understand your code when you follow the conventions, parameter in. NET starts with minute handwriting, and despite the odd names, I hope I can answer your question. (ah, and before I forget, no need to compare "== true", the compiler is smarter than it looks)

Before I go to the answer itself, another detail, the names make the meaning of your code difficult, so I may suggest names that don’t match the reality or I’ll just reverse the meaning, because I don’t know for sure what your goal is. But I’m going to take that freedom anyway, because I think you could clean up the code a lot, making it a lot less "complex," what I mean is that the complexity of the code doesn’t come from the requirement, but from yourself.

Is there any restriction on the use of Linq in your environment? one of the ways to check whether elements are part of a list would be as follows:

var idDosMateraisNoCatalogo = rd.ListarItens(IdRCM).ToList().Select(m => m.MaterialID);

var materiaisNaListaDeRCM = materiaisRequisicao.Where(m => idDosMateraisNoCatalogo.Contains(m.MaterialID));

var materiaisForaDaListaDeRCM = materiaisRequisicao.Where(m => !idDosMateraisNoCatalogo.Contains(m.MaterialID));

In this case, I traded Idmaterial for materials.

Not wanting to "advertise" but I believe to be pertinent, if you want some tips on how to improve the design of your code, take a look at www.chegadegambiarra.com