Change login user status

Question

Good morning, I am learning PHP and created a login system. I would like help with the code to change the status of logged in user.

I have a list of users who are online and, when running this script, I wanted to change the status of the user who has already spent more than 50 minutes with online status, only he is changing the status of all users.

This is my code:

$pdo = new PDO("mysql: host=localhost; dbname=pdo","root","");

$view = $pdo->prepare("SELECT agora,lastaccesso FROM users");
$view->execute();

foreach ($view as $mostra):
    $lastaccesso = $mostra['lastaccesso']; 
    $agora = $mostra['agora']; 
    $horaNova = strtotime("$lastaccesso + 5 minutes");
    $horaNovaFormatada = date("H:i", $horaNova);
    if ($horaNovaFormatada  < $agora):
        $altera = $pdo->prepare("UPDATE users SET online='" . $sim_nao . "'");
        $altera->execute();
        if($altera):
            echo "<script>window.location = 'online.php'</script>";
        else:
            echo "erro";
        endif;
endforeach;

Answer 1

See that you’re giving one update without specifying a id, thus generating a change in all users.

Another thing, if you’re making one preparação query, why not use a placeholder in the same?

In the event if, Try something like:

if ($horaNovaFormatada  < $agora):
    $altera = $pdo->prepare("UPDATE users SET online= ? WHERE id = ?");
    $altera->bindValue(array($sim_nao, $iddouser));
    $altera->execute();
    if($altera):
        echo "<script>window.location = 'online.php'</script>";
    else:
        echo "erro";
    endif;

Change the variable $iddouser by user id.

I hope you’re recording id user logged in somewhere.