How to improve this sql code?

Question

I would like to improve this code so that it does not repeat the same code in both Ifs. I don’t feel like using procedures because I don’t see the need.

DECLARE @Ordem VARCHAR (7), @Valor VARCHAR(10)
SET @Ordem = 'E'
IF @Ordem = 'E'

BEGIN
  SELECT 
  P.ParcDocFinDupNum,P.ParcDocFinSeq,P.ParcDocFinDesmPag,P.ParcDocFinDataEmissao,P.ParcDocFinDataVenc,
  P.BcoNum,P.TipoCobCod,P.ParcDocFinValOrig,P.ParcDocFinValor, P.DocFinChv,E.EntNome,
  D.EmpCod,D.DocFinTipoLanc,D.DocFinProjecao, D.DocFinChv, D.EntCod, D.DocFinEspec, GetDate() as DataHoje
  FROM DOC_FIN D 
INNER JOIN PARC_DOC_FIN P ON D.EntCod = P.EntCod 
INNER JOIN ENTIDADE E ON E.EntCod = P.EntCod
WHERE  
D.DocFinTipoLanc = 'PAG' 
AND ('Todos' = 'Não' OR D.DocFinProjecao = 'Não')
ORDER BY E.EntNome ASC, RAND()

END

IF @Ordem = 'V'
SELECT 
  P.ParcDocFinDupNum,P.ParcDocFinSeq,P.ParcDocFinDesmPag,P.ParcDocFinDataEmissao,P.ParcDocFinDataVenc,
  P.BcoNum,P.TipoCobCod,P.ParcDocFinValOrig,P.ParcDocFinValor, P.DocFinChv,E.EntNome,
  D.EmpCod,D.DocFinTipoLanc,D.DocFinProjecao, D.DocFinChv, D.EntCod, D.DocFinEspec, GetDate() as DataHoje
  FROM DOC_FIN D 
INNER JOIN PARC_DOC_FIN P ON D.EntCod = P.EntCod 
INNER JOIN ENTIDADE E ON E.EntCod = P.EntCod
WHERE  
D.DocFinTipoLanc = 'PAG' 
AND ('Todos' = 'Não' OR D.DocFinProjecao = 'Não')
ORDER BY convert(varchar,P.ParcDocFinDataVenc,103), E.EntNome ASC

END

Answer 1

You can use a CASE WHEN expression [boolean expression] THEN [express] END in the ORDER BY clause, to remove Ifs... Elses:

https://social.msdn.microsoft.com/Forums/pt-BR/70e6e2d4-39f3-4d1b-b8d4-745d9c52464f/case-no-order-by-possivel?forum=520

EDIT: In your case, it would look like this:

...
ORDER BY
CASE WHEN @Ordem = 'E' THEN E.EntNome
     WHEN @Ordem = 'V' THEN CONVERT(VARCHAR, P.ParcDocFinDataVenc, 103)
END ASC,
CASE WHEN @Ordem = 'E' THEN RAND()
     WHEN @Ordem = 'V' THEN E.EntNome
END ASC