In this case below, wouldn’t the login attribute have to be set as private for the method?

Question

I am studying inheritance in Java and one of the exercises has the code below, I think, the login attribute would not have to be set as private for the method?

public class Gerente extends Funcionario {

private int senha;

public void setSenha(int senha) {
    this.senha = senha;
}

public boolean autentica(int senha) {
    if(this.senha == senha) {
        return true;
    } else {
        return false;
    }
}

//novo método, recebendo dois params
public boolean autentica(String login, int senha) {
    //implementacao omitida
}

}

Answer 1

Without a context about the problem, it’s hard to say with precision.

But looking only at the code, I understand that at the time of authentication you will perform a comparison between the values of the Manager and values that came from the parameters.

Therefore, the login:

//novo método, recebendo dois params
public boolean autentica(String login, int senha) {
    //implementacao omitida
}

Like the password, already existing on Gerente:

private int senha;

It must be a private field of Gerente. Thus:

private String login;
private int senha;

This is because login and senha belong at the Gerente.

Then we would have something like this, using the code above:

Gerente gerente = new Gerente();
gerente.setSenha("senha");
gerente.setLogin("login");

boolen loginValido = gerente.autenticar("outroLogin", "outraSenha");

Or better yet, without the sets and using builder:

Gerente gerente = new Gerente("login", "senha");
boolen loginValido = gerente.autenticar("outroLogin", "outraSenha");

If you want to evolve this model, usually login and senha are associated with a Usuario. In this way, it would be interesting that Gerente had a Usuario with login and password.