Problems in declaring a structure

Question

I am creating a simple poker game, in this game I defined that the cards would be structs. According to my business rules, each card has a value, one name and a suit.

• The estate Valor corresponds to the range of 2 to 14 (this rule has been implemented in set of property).

• The estate Nome is derived from Valor and just converts a few numbers into letters. That is, the range from 2 to 9 will have their respective values as their name, whereas the range between 10 to 14 will have the names T, J, Q, K and Ás).

• Naipe is a char which will store a Unicode character.

As it makes no sense to exist a letter without value I created a builder. Only I can’t set the Value property through this constructor, the IDE accuses an error that is only solved if I set a number to _valor in the constructor (however it does not pass the validation and the property Value is no function). How to proceed?

The error presented is:

The 'this' object cannot be used before all its fields are assigned to

 struct Carta
    {
        private int _valor;
        public int Valor {

            get {
                return _valor;
                }

            set {
                int ValorMaximoPermitido = 14;
                int ValorMinimoPermitido = 2;

                if (value < ValorMinimoPermitido || value > ValorMaximoPermitido)
                {
                    throw new Exception($"O valor definido para a carta está fora do intervalor entre {ValorMinimoPermitido} e {ValorMaximoPermitido}.");
                }
                else
                {
                    _valor = value;
                }
            }
        }
        public char Naipe { get; }
        public string Nome
        {
            get
            {
                if (Valor > 1 && Valor < 10)
                {
                    return Valor.ToString() + Naipe;
                }
                else if (Valor == 10)
                {
                    return "T" + Naipe;
                }
                else if (Valor == 11)
                {
                    return "J" + Naipe;
                }
                else if (Valor == 12)
                {
                    return "Q" + Naipe;
                }
                else if (Valor == 13)
                {
                    return "K" + Naipe;
                }
                else if (Valor == 14)
                {                    
                    return "A" + Naipe;
                } else
                {
                    throw new Exception($"O nome para {Valor} não foi definido.");
                }
            }
        }

        public Carta (int valor, char naipe)
        {
            Valor = valor;
            Naipe = naipe;
        }

    }

Answer 1

The concept is wrong. A letter is immutable, it doesn’t make any sense to have a set in it. If you want it to be changeable you should create a class, although it still doesn’t make sense.

Remove that set and it will work. Validation must be done in the constructor.

actually has a number of other conceptual and strategy implementation errors in this code.

It would be nice to have C# Adts, as there is at least the definition of the cards would be better implemented as enum, it would save many problems and be easier to program.

Some details:

• Nome is not derived from Valor.
• All characters in C# are Unicode.
• The IDE is not responsible for parsing the code.
• use Exception has two problems, is too generic and is being used as flow control.
• Has problems of nomenclature, typing and even the values used in the cards.