Is it wrong for me to use a static method to retouch a collection of objects?

Asked

Viewed 445 times

18

First of all, I know that I should not go out making classes with various static methods but in this case that I bring here, I do not understand why it can be considered bad practice.

Let’s say I have a MVC structure, in my model, I have all the respective methods of my CRUD, create, read, update and delete. However, I always make a static method called list, this in turn, can return a Collection (array even in the case in php) with several objects of the specific model and there, for each object, I have your CRUD methods. I see no problem in listing to be static, since it will not interact directly with anything else in my class.

I did a lot of research on the subject and I couldn’t find anything to change my mind, so I wanted to bring this discussion here.

php oop

  • Unless you have misunderstood... Why does the list method return multiple objects? What application do you make of this?

  • For example, I have a Person Class. I can insert, read, update and delete it. But and when I want to list for example, all the People I have. Present a list to the user. In this case, I have the practice of using a static method, because I’m not going to interact directly with other methods or attributes of the Person class, but still, I’m doing something related to Person, so, why not, use a static method, that, instantiating one person for each line that my query returns and I return that list

  • Related: What is the function of a static method?

  • I saw no problem in this approach, it may even be practical. I may be wrong, but the Laravel (Laravel.com) framework does something similar for some methods.

  • When we think that a static method would be a "class method" and would be executed without needing an instance of it to list objects, I don’t think I see any problem in this approach. It even makes a certain sense to me by analyzing the concepts themselves. Only one question arose that is related to the connection with the Database in this static method: how is this connection made? All programmed in the static method? I imagine so because it is static.

  • I believe there is no mistake in using static methods for this, but it seems to me that your class is more responsible than just a model. This is common when using some Activerecord type Orm as the Eloquent of the Laravel. To avoid this type of approach, it is common to implement the Pattern Repository, and decouple the integration model with the BD.

Show 1 more comment

2 answers

1

Assuming that its reason is to control several registers at different times, this makes sense, which is even applied in the Laravel with the method Route , which is used to receive instances from other classes, and may have several responsibilities, as in this example:

Way: http://127.0.0.1:8000/api/products/1

Route::get('produtos/{id}/', function (Request $request, Produtos $produtos) {
   //
});

In the example the method Route flame of static form or method Get, by manipulating the instances of Request and of Products, these classes could have several other responsibilities within them such as the Controllers of the MVC standard, but this applied poorly, can lead to a problem that is the encapsulation of your code, making maintenance costly.

Continuing the answer still using Laravel as an example, in this case it fits the design pattern 'Facade' (Facade), where a 'facade' (the Route) is responsible for the entire later subclass chain.

References:

Laravel Facades Laravel Routing

Standard Facade

Related:

0

Today the development is based on various patterns of projects, and some of these patterns (or all, I do not know) are used dependency injections ie injecting a class.

I also suggest implementing interfaces in their applications because they help to improve the code and putting everything together becomes easier a possible maintenance after.

I recommend you give a study on design patterns will help you evolve a lot as a developer.

Browser other questions tagged php oop

You are not signed in. Login or sign up in order to post.