What’s wrong with parole?

Question

What the error in the parole below and how to resolve?

private void Botão_Click(object sender, EventArgs e)
{
    if(Pbox.Show();)
        Pbox.Hide();
    else(Pbox.Hide();)
        Pbox.Show();
}

private void Pbox_Click(object sender, EventArgs e)
{

}

Answer 1

The syntax is quite wrong. Anyway there is an easier way to do what you want:

private void Botão_Click(object sender, EventArgs e) {
    PBox.Visible = !Pbox.Visible;
}

I put in the Github for future reference.

If I were to write in the form of the question it should be so:

if (Pbox.Visible) {
    Pbox.Hide();
} else {
    Pbox.Show();
}

The methods Hide() and Show() do not return anything so cannot be used as a condition of if that expects a boolean. To know if the control is visible use the property Visible. It is not necessary to use a else since this property can only return two valore, or is true, or is false, if true executes the block of the if, otherwise it will execute the else, independent of anything else. Even if it were the case to use a condition, it could only with a else if.