Bubble Sort in list

Question

I’m trying to order a simple chained list, but I’m not succeeding, only changes the first node because the value is smaller, the rest does not change.

void ordenar(lista **l) {

    int tam = tamanho((*l));
    lista *prev, *current = (*l)->prox;

    for(int i=0; i<tam - 1; i++) {
        prev = *l;
        for(int j=0; j<tam; j++) {
            if(prev->data > current->data) {
                troca(prev, current);
            }
            current = prev->prox;
        }
        prev = prev->prox;
    }
}

Answer 1

The current = (*l)->prox must be inside the first loop to start over every time.

The prev = prev->prox must be inside the second loop to go through the list.

And the current = prev->prox must be exchanged for current = current->prox to continue browsing the list.

Like the current already begins with the second element, the second loop for should go up to tam-1 not to access a non-existent element.

void ordenar(lista **l) {

    int tam = tamanho((*l));
    lista *prev, *current;

    for(int i=0; i<tam - 1; i++) {
        prev = *l;
        current = (*l)->prox;
        for(int j=0; j<tam -1; j++) {
            if(prev->data > current->data) {
                troca(prev, current);
            }
            current = current->prox;
            prev = prev->prox;
        }
    }
}

I believe this should be working, test your code and see if it’s OK or if there’s still something wrong.