Dynamic calculations in Rails

Question

I hope you can help me.

I have a Rated who owns evaluations, have several calculations to determine whether or not it will pass an evaluation step. For example one of these calculations is calcula_pontuacao_minima()

#Cálculo definido pela resolução 1
def calcula_pontuacao_minima(avaliado)
  calcula_porcentagem(avaliado.avaliacoes)>60 #onde esta soma todas as notas do avaliado e retorna a porcentagem de aproveitamento
end

My problem here is the appearance of resolutions that alter the calculation, so that all the evaluated before that resolution, must be evaluated for calculations old and new evaluated shall be classified using calculations changed. For example a resolution changes the minimum value to 50%

#Cálculo definido pela resolução 2
def calcula_pontuacao_minima(avaliado)
  calcula_porcentagem(avaliado.avaliacoes)>50 #onde esta soma todas as notas do avaliado e retorna a porcentagem de aproveitamento
end

And if in a future they still change to instead of taking the percentage, the minimum value is compared to the total value of the ratings

#Cálculo definido pela resolução 3
def calcula_pontuacao_minima(avaliado)
  calcula_total(avaliado.avaliacoes)>70 #onde esta soma todas as notas do avaliado onde o máximo é 120
end

So for example Evaluated which had their evaluations carried out before the date X that defined the resolution 2, will be evaluated by the first calculation after that date X will be evaluated by the second calculus, and after the date Y where the resolution 3, will be evaluated by the third calculation.

Any idea how this can be fixed? It would be a good idea to store the database-level calculations?

Answer 1

The resolution I would make would be to use a created field (which according to your comment will be created later) or the created_at and based on the resolution creation date (considering you have a table of resolutions or the dates they were), I would use only the creation dates of resolutions, considering, for example, a date X for resolution 1, a date Y for resolution 2 and Z for resolution 3. If you want to run the method for each evaluated, this would be:

def calcula_pontuacao_minima(avaliado)
  if(avaliado.created_at < Y)
    return calcula_total(avaliado.avaliacoes) > 60
  elsif (avaliado.created_at >= Y && avaliado.created_at < Z)
    return calcula_total(avaliado.avaliacoes) > 50
  else
    return calcula_total(avaliado.avaliacoes) > 70
  end
end

In case you want to do for everyone at once (what I advise), the ideal would be to do as follows:

def calcula_pontuacao_minima
  resultado = []
  Avaliado.where('created_at < ?', Y).all.each do |avaliado|
    a.push(calcula_total(avaliado.avaliacoes) > 60)
  end
  Avaliado.where('created_at >= ? AND created_at < ?', Y, Z).all.each do |avaliado|
    a.push(calcula_total(avaliado.avaliacoes) > 60)
  end
  Avaliado.where('created_at >= ?', Z).all.each do |avaliado|
    a.push(calcula_total(avaliado.avaliacoes) > 60)
  end
  return a
end

I don’t know if this is what you want, but it’s what I’ve been able to infer from your question.