How do I display what’s on the list?

Question

I have this method that adds things to the list:

 public Pedido adicionarPedido(int quantidade, String nome){

        lista.add(new Item(quantidade, nome ));
            return this;
 }

And I’ve entered that class into the list attributes :

List<Item> lista = new ArrayList<Item>();

I am asking to display in the toString method the list data plus the person’s name:

     public Pedido ToString() {
        mensagem = "Pedido [lista=" + lista.get(0) +  lista.get(1) + ", cliente=" + cliente.getNome() + "]";
          return this;
     }

The problem is that the console is being printed like this:

Pedido [lista=teste.Item@15db9742 teste.Item@6d06d69c, cliente=Aline Gonzaga]

But I want the list items printed out.

How can I do that?

Answer 1

To me it’s an abuse to use the ToString() for this, this method was not created for this kind of thing.

You should take the element and the class member, and you should do it by sweeping the list, something like that:

public Pedido ToString() {
     mensagem = "Pedido do Cliente " + cliente.getNome() + "\n";
     for (Item item : lista) mensagem += "Quantidade: " + item.quantidade + " Produto: " + item.nomeProduto + "\n";
     return this;
}

I put in the Github for future reference.

I could only answer by looking at your previous question. All this code still has several other problems.

Answer 2

Your class Item need to overwrite the method toString. By default the method shows a hashing unique generated by JDK. Then it would be something like:

@Override
public String toString() {
  return String.valueOf(this.getQuantidade()) + " " + this.getNome();
}

Whenever a method that receives a String as parameter and an object is passed, the method toString is invoked. In the case of a list, the method of your items is invoked, causing the effect you described (Item@...).

Right after you can also overwrite the order class method:

@Override
public String toString() {
  return "Pedido: lista=" + this.getLista() + ", cliente=" + this.getCliente().getNome();
}

So the following call:

System.out.println(pedido);

Will produce:

Pedido: lista=[1 Produto 1, 2 Produto 2], cliente=Aline Gonzaga

I also noticed that you used the method ToString capital letters. By the code convention Java methods should start with lower case letter, except constructors. Then you should override the method toString.

Regarding the use and suggestion on the abuse of toString in this answer, we have this topic in stackoverflow which indicates that the use is interesting for debugging purposes, so maybe to show a final message in your application is better another method to define the message.