Convert string to integer

Question

I can’t convert my text TextBox in one piece.

namespace Pag98_Exe1
{
    public partial class frmveiculos : Form
    {
        public frmveiculos()
        {
            InitializeComponent();
        }

        Veiculos veiculos = new Veiculos(); //Declarando a classe veiculos

        private void btnenviar_Click(object sender, EventArgs e)
        {
            if(mskTxtplaca.Text != "" && cbxmarca.Text != "" && txtanofabricacao.Text != "")
            {
                veiculos.Placa = mskTxtplaca.Text; //Atribuindo o valor de Placa ao texto do TextBox
                veiculos.Marca = cbxmarca.Text;
                veiculos.AnoFabricacao(int.Parse(txtanofabricacao.Text)); //Passando o valor do TextBox para inteiro e atribuindo ao TextBox
            }
        }
    }
}

Answer 1

Since the text comes from a control that the user can type there is no guarantee that the text can be converted to integer, so you have to try to do, if it works out do what you want, otherwise you need to treat it in some way, issue an error, put a default value, something like that. This is done with the method TryParse(). Other solutions are failures, do not use unless you are sure that the value can be converted, which does not seem to be the case. I have my doubts whether the rest of the logic is adequate, but I cannot speak without knowing the requirements.

private void btnenviar_Click(object sender, EventArgs e) {
    if(mskTxtplaca.Text != "" && cbxmarca.Text != "" && txtanofabricacao.Text != "") {
        veiculos.Placa = mskTxtplaca.Text;
        veiculos.Marca = cbxmarca.Text;
        int anoFabricacao;
        if (int.TryParse(txtanofabricacao.Text, out anoFabricacao) {
            veiculos.AnoFabricacao = anoFabricacao;
        } else {
            //aqui coloque o que deve fazer se a conversão falhar
        }
    }
}

In C# 7 can make it a little simpler:

private void btnenviar_Click(object sender, EventArgs e) {
    if(mskTxtplaca.Text != "" && cbxmarca.Text != "" && txtanofabricacao.Text != "") {
        veiculos.Placa = mskTxtplaca.Text;
        veiculos.Marca = cbxmarca.Text;
        if (int.TryParse(txtanofabricacao.Text, out var anoFabricacao) {
            veiculos.AnoFabricacao = anoFabricacao;
        } else {
            //aqui coloque o que deve fazer se a conversão falhar
        }
    }
}

I put in the Github for future reference.

Answer 2

Your post is a little confused, so what I understood from the code tries this solution:

veiculos.AnoFabricacao = int.Parse(txtanofabricacao.Text);