What’s wrong with my code? I’m a beginner

Question

I want to create an employee class with the specifications below, but I cannot return the show data method and the method calculate salary. It gives compilation errors when calling the methods, I wanted to know how to define their call, because there is something wrong. Thank you very much.

The official shall have:

• Name, age, hourly wage and hours worked in the month.
• Class attributes must be encapsulated.
• there must be getters methods for everyone and setters for salary per hour and hours worked in the month.
• There is a rule that the hourly wage should be between 10 and 200.
• There is a rule that the hours worked in the month may not exceed 160 hours.
• the method mostrarDados() is used to display all employee information in the console.
• the method calcularSalario() returns the value of the employee’s salary. This amount is obtained by multiplying the employee’s hourly wage and the hours worked in the month.

Class Funcionario:

public class Funcionario {

      private String        nome;
      private int          idade;
      private int   salario_Hora;
      private int horas_trab_mes;


    public double getSalario_Hora() {
        return salario_Hora;
    }
    public void setSalario_Hora(double salario_Hora) {
        if (salario_Hora>10 & salario_Hora<=200){
            this.salario_Hora = salario_Hora;
        }

    }
    public double getHoras_trab_mes() {
        if (horas_trab_mes<=160){
            return horas_trab_mes;  
        }

    }
    public void setHoras_trab_mes(double horas_trab_mes) {
        this.horas_trab_mes = horas_trab_mes;
    }
    public String getNome() {
        return nome;
    }
    public int getIdade() {
        return idade;
    }

    public void mostrarDados(){
        System.out.println("O nome do funcionário é"+getNome());
        System.out.println("A idade do funcionário é"+getIdade);
        System.out.println("O número de horas trabalhadas do funcionário é "+horas_trab_mes);
        System.out.println("O salário por hora do funcionário é"+salario_Hora);
        }

    private double calcularSalario(){
        return salario_Hora*horas_trab_mes;
    }


}

Class Aplicacao:

public class Aplicacao {

    public static void main(String[] args) {

        Funcionario f= new Funcionario();
        f.setHoras_trab_mes(100);
        f.setSalario_Hora(100);

        System.out.println("Os dados do funcionário são:"+ f.mostrarDados();
        System.out.println("O salário do funcionário é:"+ f.calcularSalario();

        }
    }
}

When trying to compile, I get the following errors:

C:\Projetos\Funcionario\src\Aplicacao.java:9: error: ')' expected
        System.out.println("Os dados do funcionário são:"+ f.mostrarDados();
C:\Projetos\Funcionario\src\Aplicacao.java:10: error: ')' expected
        System.out.println("O salário do funcionário é:"+ f.calcularSalario();
C:\Projetos\Funcionario\src\Aplicacao.java:14: error: class, interface, or enum expected
}
3 errors

C:\Projetos\Funcionario\src\Funcionario.java:14: error: incompatible types: possible lossy conversion from double to int
            this.salario_Hora = salario_Hora;
C:\Projetos\Funcionario\src\Funcionario.java:25: error: incompatible types: possible lossy conversion from double to int
        this.horas_trab_mes = horas_trab_mes;
C:\Projetos\Funcionario\src\Funcionario.java:36: error: cannot find symbol
        System.out.println("A idade do funcionário é"+getIdade);
  symbol:   variable getIdade
  location: class Funcionario
3 errors

Answer 1

I put the description of the most obvious compilation errors in comments:

public class Aplicacao {

    public static void main(String[] args) {

        Funcionario f= new Funcionario();
        f.setHoras_trab_mes(100);
        f.setSalario_Hora(100);

        // Faltou um fecha parênteses.    
        System.out.println("Os dados do funcionário são:"+ f.mostrarDados();

        // Faltou um fecha parênteses.
        System.out.println("O salário do funcionário é:"+ f.calcularSalario();

        // Você está abrindo duas chaves e fechando três.
        }
    }
}

public class Funcionario {

      private String        nome;
      private int          idade;
      private int   salario_Hora;
      private int horas_trab_mes;


    public double getSalario_Hora() {
        return salario_Hora;
    }
    public void setSalario_Hora(double salario_Hora) {
        if (salario_Hora>10 & salario_Hora<=200){
            // O atributo salario_Hora é int, enquanto que você está tentando
            // atribuir-lhe um double. A linguagem java não permite isso diretamente
            // sem um cast porque iria perder precisão. Afinal como você colocaria
            // um número fracionário em algo que só aceita inteiros sem fazer
            // nenhuma conversão, adaptação ou arredondamento?
            this.salario_Hora = salario_Hora;
        }

    }
    public double getHoras_trab_mes() {
        if (horas_trab_mes<=160){
            return horas_trab_mes;  
        }

    }
    public void setHoras_trab_mes(double horas_trab_mes) {
        // Novamente, tentando colocar double no int.
        this.horas_trab_mes = horas_trab_mes;
    }
    public String getNome() {
        return nome;
    }
    public int getIdade() {
        return idade;
    }

    public void mostrarDados(){
        System.out.println("O nome do funcionário é"+getNome());

        // getIdade é um método, então faltou os parênteses.
        System.out.println("A idade do funcionário é"+getIdade);
        System.out.println("O número de horas trabalhadas do funcionário é "+horas_trab_mes);
        System.out.println("O salário por hora do funcionário é"+salario_Hora);
        }

    private double calcularSalario(){
        // Aqui você havia esquecido o ponto-e-vírgula,
        // mas você já editou isso na pergunta.
        return salario_Hora*horas_trab_mes;
    }


}

Most of these build errors are simple to solve, so I leave it to you. As for the problem of putting double in the int, it’s just you decide once and for all if the attribute is double or int and make the Setter parameters and the getter return value reflect your choice.

Finally, there are still other problems about coding style. Naming conventions dictate that method names, attributes and local variables should be composed of concatenated words without spaces, the first letter of each lowercase word and all other lowercase words, except for the first letter which must always be lowercase. Therefore, these identifiers are with a good nomenclature:

• nome
• idade
• getNome
• getIdade
• calcularSalario

Already these have a bad nomenclature:

• salario_Hora: Should be salarioHora
• horas_trab_mes: Should be horasTrabalhadasMes - Don’t abbreviate words if you don’t have an excellent reason for it.
• getSalario_Hora: Should be getSalarioHora
• setSalario_Hora: Should be setSalarioHora
• getHoras_trab_mes: Should be getHorasTrabalhadasMes
• setHoras_trab_mes: Should be setHorasTrabalhadasMes

Done that, now there will still be some other more complicated compilation bugs, here they go:

    public double getHoras_trab_mes() {
        if (horas_trab_mes<=160){
            return horas_trab_mes;  
        }

    }

If the number of hours worked is less than or equal to 160, it will be returned. But, what if it is not? The answer is that this method is wrong and it should return the independent value of anything, the if is unnecessary.

The method mostrarDados is void. That is, it does not produce result. He himself is showing the output through the System.out.println rather than return some value. This behavior is incompatible with what is in your class Aplicacao:

    System.out.println("Os dados do funcionário são:"+ f.mostrarDados();

Instead, just call the mostrarDados() directly and itself will take care of the task of showing the data:

    f.mostrarDados();

And if you already have a method to show the data, then you don’t need to do it later:

    System.out.println("O salário do funcionário é:"+ f.calcularSalario();

After all, if you have a method that serves to show the data on the console, it makes more sense to put it inside.

With that, only these two rules are missing:

• There is a rule that the hourly wage should be between 10 and 200.
• There is a rule that the hours worked in the month may not exceed 160 hours.

And you are on the right track, the ideal is to do this within the setters. When these restrictions are satisfied, it is easy, just set the value of the fields and ready. When not satisfied, you can make three possible paths:

• Do nothing - that’s what you’re doing at the moment.
• Write something on System.out.println saying that the method refused to set the value.
• Throw an exception - what is the right treatment for robust systems, but you are at a level too beginner to be able to handle this case, since exception treatment is something that is at a significantly more advanced level than what you are at the moment.

I hope I’ve helped you.

Answer 2

System.out.println("Os dados do funcionário são:"+ f.mostrarDados());
System.out.println("O salário do funcionário é:"+ f.calcularSalario());

At a glance there are many incomplete calls; missing check there ...