Comparison of dates

Question

I want the message to appear when the user enters no date or the initial date is longer than the final date. The code I made was this:

/**
 * @Assert\True(message = "Erro! Verifique as horas. Data inical não pode ser maior que a data final.")
 */
public function isHoraFim() 
{
    if ($this->horainicial > $this->horafim) 
    {
        return false;
    } 
    else 
    {
        return true;
    }

    if ($this->horainicial || $this->horafim) 
    {
        return false;
    }    

    return $this->horainicio < $this->horafim;
}

But the error message always appears, except when the user inserts no date.

Answer 1

I leave my question here to those who have the same question as me. What happened to me was that I had the same name as my variable.

 /**
 * @Assert\True(message = "Erro! Verifique as horas. Data inical não pode ser maior que a data final.")
 */
public function isHorasCheck() {
        return ($this->horainicio < $this->horafim);
}

Which I added, but which wasn’t in the question, I thought it would be better this way.

 /**
 * @Assert\True(message = "Erro! Verifique as horas. Data inical não pode ser maior que a data final.")
 */
public function isHorasCheck() {

    if ($this->horafim === null){
        return true;
    }
    if ($this->horainicio === null){
        return false;
    }
    else{
        return ($this->horainicio < $this->horafim);
    }

}

Both way they work now is just seeing what’s best for you.

Answer 2

If you need to return true or false, a simple line solves:

/**
 * @Assert\False(message = "Erro! Verifique as horas. Data inicial não pode ser maior que a data final.")
 */
public function isHoraFim() 
{
    return (!$this->horainicial || !$this->horafim || $this->horainicial > $this->horafim);
}

Or:

/**
 * @Assert\True(message = "Erro! Verifique as horas. Data inicial não pode ser maior que a data final.")
 */
public function isHoraFim() 
{
    return ($this->horainicial && $this->horafim && $this->horainicial < $this->horafim);
}