Error handling in js Node

Question

I’m doing an error treatment that if a wrong id is passed by url he returns a error 400, but when I take the test it returns a error 200 one more message

"error": "Error", "message": "Cast to ObjectId failed for value \"5d69f4aa827b491c678c50a\" at path \"_id\" for model \"Product\""

Follow the controller:

router.get('/product-view/:id', async (req, res) => {    
    const id = req.params.id    
    try{    
        if(!id) return res.status(404).send({ error: 'Produto não encontrado'})    
        console.log(id);        
        const product = await Product.findById(id);        
        res.send(product);        

    }catch(error){    
       res.send({    
            error: 'Error',
            message: error.message    
       })    
    }       
});

Answer 1

Problem: the id recovered is a different type than the method findById understands, in this case this method needs a Objectid (mongoose.Schema.Types.ObjectId) to fetch information from the bank mongodb, or an object with the following structure {_id: id} or a string with the name _id, as described in its documentation.

Particularly speaking I prefer to always put a guy who in the case is Objectid, example:

router.get('/product-view/:id', async (req, res) => {    
    const id = req.params.id    
    try{    
        if(!id) return res.status(404).send({ error: 'Produto não encontrado'})    
        const _id = new ObjectId(id);  // instância requerida pelo seu código
        const product = await Product.findById({_id:_id}); // ou simplificando {_id}        
        res.send(product);        

    }catch(error){    
       res.send({    
            error: 'Error',
            message: error.message    
       })    
    }       
});

and this guy Objectid is mongoose.Types.ObjectId which is the type of data recorded in your mongodb.

or quick fix in your code:

router.get('/product-view/:id', async (req, res) => {    
    const id = req.params.id    
    try{    
        if(!id) return res.status(404).send({ error: 'Produto não encontrado'})      
        const product = await Product.findById({_id: id});        
        res.send(product);        

    }catch(error){    
       res.send({    
            error: 'Error',
            message: error.message    
       })    
    }       
});

^Referent:

• Schematypes
• Schematypes - Objectid
• Find By ID in Mongoose

^Examples

• Can’t find Documents Searching by Objectid using Mongoose
• Mongoose find by Objectid