Incorrect Printed Form Values

Question

I don’t know where I’m going wrong.

#include <stdio.h>

int main (){
int i, num, soma, maior, menor;
float media;

printf ("Informe 10 valores:\n");
for (i=1; i<=10; i++){
    scanf ("%d", &num);
    if (i==0){
        maior=num;
        menor=num;
    }
    else{
        if (num > maior){
            maior=num;
        }
        if (num < menor){
            menor=num;
        }
}
soma = soma + num;
media = soma / 10;
}
printf ("Media: %.2f", media);
printf ("\nMaior: %d", maior);
printf ("\nMenor: %d", menor);
}

Answer 1

There are several errors, probably a mix of conventions without you have noticed:

1. i never zero, so never start the values of menor nor of maior
2. The value of soma is not initialized, so loads memory junk
3. The calculation of media is being done with whole arithmetic
4. You don’t need to average every iteration

Solving the problems

The first is to iterate starting at 0 and going up to 10 in the open interval. That is to say:

for (i = 0; i < 10; i++) ...

Simply declare the variable soma already initialized solves the problem:

int i, num, soma = 0, maior, menor;

Remove the average calculation from the middle of the iteration, while maintaining the soma resolves item 4.

At the end of the iteration, dividing by 10 as floating point resolves item 3:

media = soma / 10.0f

Answer 2

Below is the code with some corrections.

#include <stdio.h>

    int main (){
    int i, num, soma, maior, menor;
    float media;

    printf ("Informe 10 valores:\n");
    soma=0;//Faltava inicializar a variável soma, estava com valor "lixo" da memória
    for (i=0; i<10; i++)//inicializei em 0, com i=1 ele não estava tratando todos os valores de num
    {
        scanf ("%d", &num);
        if (i==0){
            maior=num;
            menor=num;
        }
        else{
            if (num > maior){
                maior=num;
            }
            if (num < menor){
                menor=num;
            }
    }
    soma = soma + num;//Somatório de todos os 10 valores
    }
    media = soma / 10.0;//Soma dividido por 10.0, divisão de int por float resulta em float
    printf ("Media: %.2f", media);
    printf ("\nMaior: %d", maior);
    printf ("\nMenor: %d", menor);
    }

I did the test with values from 1 to 10 and got the following output:

    Media: 5.50
    Maior: 10
    Menor: 1