How to build a class correctly with access methods?

Question

How do I join several variables into a single object? How do I arrange the following code?

<?php
class Produto {
    //Atributos
    var $cpu;
    var $mb;
    var $psu;

    //Getters & Setters
    function setProduto($produto, $produto1){
        $this->cpu = $produto;
        $this->mb = $produto1;
    }


    function getProduto(){
        return $this->cpu;
        return $this->mb;
    } 
}?>

Code to access the class

<?php
include('exibindo_classes.php')
$produto = new Produto();
$produto->setProduto('Core i7 7700', 'Z270');

echo $produto->getProduto();
?>

Answer 1

This is so wrong. My suggestion is to focus on the fundamentals, on doing the procedural very well, when you see that you need it and realize that you already know the basics so think about OOP which is less useful than speaking, even less in PHP, and more difficult than it seems. Doing OOP right is so hard to do that it usually comes out better not to use. Of course there are problems that benefit a lot from OOP and in general can be very useful when one already has enough experience in everything else.

For example, it still lacks conditions to give good names to things, which is something basic and should be mastered before doing OOP.

Almost always getters and setters is not as good an idea in PHP as it is in Java. There are even properties in PHP that would be a little better. I’ll leave it the way you want, but I already say that this is the way that almost everyone does, but it is not the most correct form. And almost everyone does it because they don’t learn properly, they’re just reproducing what others do wrong too.

It is very difficult to do OOP right without seeing the whole, without knowing every detail, without doing everything as one thing, which does not have in this code, but to take a step:

<?php
class Produto {
    private $cpu;
    private $mb;
    private $psu;
    public function __construct($cpu, $mb) {
        $this->cpu = $cpu;
        $this->mb = $mb;
    }
    function getCpu() {
        return $this->cpu;
    } 
    function setCpu($cpu) {
        $this->cpu = cpu;
    } 
    function getMb() {
        return $this->mb;
    } 
    function setMb($mb) {
        $this->mb = mb;
    } 
}

$produto = new Produto('Core i7 7700', 'Z270');
echo $produto->getCpu();
?>

Behold working in the ideone. And in the repl it.. Also put on the Github for future reference.

Note that I used a builder. This is how you start an object. You don’t just have one getters and a Setter for the whole object, you have one for each attribute. If necessary. Possibly a __toString() could be useful, among other things, but almost always people use wrong (see, and more here).

Answer 2

I don’t see much point in creating getters and setters in PHP in many cases. Of course it will depend a lot on the context, how the class was designed and what use you intend to make of its instances. Sometimes what you need is a simple object with public properties. For example:

<?php
class Produto {
    public $cpu;
    public $mb;
    public $psu;

    public function __construct($cpu, $mb, $psu) {
        $this->cpu = $cpu;
        $this->mb = $mb;
        $this->psu = $psu;
    }
}

$produto = new Produto('Core i7 7700', 'Z270', '500W');
echo $produto->cpu; // Core i7 7700
$produto->mb = 'Z271';
echo $produto->mb; // Z271

^{https://ideone.com/aD5cGk}

Sometimes not even that, just an associative array:

$produto = [
    'cpu' => 'Core i7 7700',
    'mb' => 'Z270',
    'psu' => '500W'
];

echo $produto['cpu'];
$produto['mb'] = '...';
// ...

Answer 3

I don’t know if it’s what you want, but the function can’t have multiple returns, so you can use arrays. more or less like this:

function getProduto(){
    return array('variavelcpu' => $this->cpu, 'variavelmb' => $this->mb);
} 

Then you can access them like this:

$produtoretorno = $produto->getProduto();
echo $produtoretorno['variavelcpu'];
echo $produtoretorno['variavelmb'];

From what I understand you’re needing would be this, if it’s something else, try to give more details.

Answer 4

cracking my head a little.. I came to the following conclusion.. and that worked out by the way.. only that I n am with separate files(the class in a separate file from the view)..

<?php
class Produto {
    //Atributos
    private $cpu;
    private $mb;
    private $psu;

    //Getters & Setters
    function setProduto($produto, $produto1, $produto2){
        $this->cpu = $produto;
        $this->mb = $produto1;
        $this->psu = $produto2;
    }


    function getProduto(){
        return $this->cpu;
        return $this->mb;
        return $this->psu;
    } 

    function mostrarProduto(){
        echo $this->cpu .$this->mb .$this->psu;
    }
}

//Exibindo a classe
$produto = new Produto();
$produto->setProduto('Core i7 7700 <br />', 'Z270E STRIX <br />', 'CX750M <br />');
$produto->mostrarProduto();
?>

am I correct in using this way?? I am taking a WEB development course.. I am in the Object Orientation module in PHP.. I appreciate all the help you’re giving me.