Does the PHP method have line limits?

Question

The size of the method is 22 lines. (20 Allowed)

Netbeans gives me this "warning," so why? It’s a PHP rule?

What’s best:

1. A great method with all the code he needs.
2. Split this code into smaller methods
3. There is an appropriate number of lines in a method?

Answer 1

That’s a suggestion netbeans no line or character limit for a method. The ideal is that it solves only one problem or has only one responsibility.

1) A large method with all the code it needs.

In this situation there is a great possibility that the method is doing several things.

2) Divide this code into smaller methods

In some cases it is the best solution.

3) There is an appropriate number of lines in a method?

Not.

Answer 2

The rray response is good, just add one thing: You let the less specific methods have to do with code reuse, with less specific methods you can reuse them more.

Maybe this is best seen when you’re at the design part of the application or later when you’re going to review the code and see that there’s a lot of repeated stuff that could be done once and repurposed more than once.

Answer 3

Netbeans gives me this "warning," so why? It’s a PHP rule?

According to this thread in the bug tracking of Netbeans, is just one hint which can be disabled in Editor > Hints.

And no, that’s not a rule of PHP. To the PHP we usually follow the PSR, acronym for PHP Standards Recommendations, where there are standards defined by the community to standardize development with language. In your specific doubt, there is the topic 2.3. Lines which says the following:

• The line should not have a strict limit on its length. The maximum should be 120 characters, displaying a warning but not causing error. The ideal is that it is 80 characters or less, but if necessary it can be broken.
• One command per line;

1. A great method with all the code he needs.
2. Split this code into smaller methods
3. There is an appropriate number of lines in a method?

These three questions go deeper into development patterns and architectures, so I’ll try to answer in a single shot:

According to this thread in Engineering / se software, Robert Martin in his book, Clean Code: A Handbook of Agile Software Craftsmanship, says:

The first rule of function is that they should be small. The second rule is that they should be smaller than that. They should not have more than 100 lines. They should hardly exceed 20 lines.

If a method is large and there really is a need for it, it is a specific case of your software. But if you can take a closer look at it, make sure she comes in according to Princípio da Responsabilidade Única, also Robert Martin says that she should be responsible for only one thing.

The division into smaller codes also comprises the following topics:

• Testability
• Cohesion and Coupling
• Understanding

Reading tip:

• Refactoring: Improving the Design of Existing Code 1st Edition by Martin Fowler

• Patterns of Enterprise Application Architecture 1st Edition by Martin Fowler

• Clean Code: A Handbook of Agile Software Craftsmanship 1st Edition by Robert C. Martin