Comparing words from a text to an Enum’s list

Question

I have an Enum that contains a list of values. I have a method where I receive text as a parameter. This method, besides going through Enum, breaks the text by words. The main function of the method is to see if there is any word in the text that is equal to any value in the Enum. The code is below:

public String checkTipo(String texto) {
        List<TipoPokemon> lista = Arrays.asList(TipoPokemon.values());
        String palavras[] = texto.split(" ");

        for(int i=0 ; i < lista.size() ; i++){
        for (String palavra : palavras){
            String tipo = lista.get(i).getNome();
                if (palavra.toLowerCase().equals(tipo)){
                    return "Olá";
                }
            }
        }

        return "";
    }

My Enum is:

package br.com.pokemax.modelo;

public enum TipoPokemon {

    FIRE("FIRE"),
    WATER("WATER"),
    GRASS("GRASS"),
    ELECTRIC("ELECTRIC"),
    ICE("ICE"),
    DARK("DARK"),
    GHOST("GHOST"),
    FAIRY("FAIRY"),
    PSYCHIC("PSYCHIC"),
    DRAGON("DRAGON"),
    POISON("POISON"),
    GROUND("GROUND"),
    ROCK("ROCK"),
    NORMAL("NORMAL"),
    BUG("BUG"),
    FIGHTING("FIGHTING"),
    STEEL("STEEL"),
    FLYING("FLYING");

    private String nome;

    private TipoPokemon(String nome) {
        this.nome = nome;
    }

    public String getNome() {
        return nome;
    }

    public void setNome(String nome) {
        this.nome = nome;
    }

}

I’m trying to debug and the part where I create the variable guy, he returns in foreach and does not check the if, I need to compare word with enum, someone can help me ?

Answer 1

You don’t need to define the name that way because everyIn has a method name() that does exactly what your getNome() ago.

In addition, every Enum has a method valueOf(String) that makes a part of what your checkTipo(String) ago.

Your code would look like this:

package br.com.pokemax.modelo;

import java.util.Locale;

public enum TipoPokemon {
    FIRE, WATER, GRASS, ELECTRIC, ICE, DARK, GHOST, FAIRY, PSYCHIC,
    DRAGON, POISON, GROUND, ROCK, NORMAL, BUG, FIGHTING, STEEL, FLYING;

    public static String checkTipo(String texto) {
        String palavras[] = texto.split(" ");
        for (String palavra : palavras) {
            try {
                TipoPokemon tipo = valueOf(palavra.toUpperCase(Locale.ROOT));
                return "Olá";
            } catch (IllegalArgumentException e) {
                // Ignora a exceção e continua no for.
            }
        }
        return "";
    }
}

I just don’t understand why the method returns "Olá" or "" instead of returning boolean or the TipoPokemon found.

Here’s a test for him:

public static void main(String[] args) {
    System.out.println(TipoPokemon.checkTipo("ROCK"));
    System.out.println(TipoPokemon.checkTipo("bug"));
    System.out.println(TipoPokemon.checkTipo("banana"));
    System.out.println(TipoPokemon.checkTipo("banana cereja acerola"));
    System.out.println(TipoPokemon.checkTipo("banana cereja dark acerola"));
}

Here’s the way out:

Olá
Olá


Olá

See here working on ideone.

Answer 2

One option without needing to capture exception:

public boolean checkTipo(String texto) {
    List<String> palavras = Arrays.asList(texto.toUpperCase().split(" "));

    for (TipoPokemon tipoPokemon : TipoPokemon.values()) {
        if (palavras.indexOf(tipoPokemon.name()) > -1) {
            return true;
        }
    }
    return false;
}

As clarified in @Victor Stafusa’s reply you do not need to assign a string to each Enum item if the string is equal to the item’s name; the function name() I already extracted this string for you.

Testing:

@Test
public void checkTipo() {
    assertTrue(checkTipo("não dark outro"));
    assertFalse(checkTipo("não darkness outro"));
}