Method does not return correct value

Question

I have the following code:

public class Main {
    public static void Main (String[] args) {
        Metodo R = new Metodo();
        Scanner entrada = new Scanner(System.in);
        int[] valores = new int[10];
        int i = 0;
        while (i < valores.length) {
            System.out.println("Insira um número.");
            valores[i] = entrada.nextInt();
            i++;
        } System.out.println(R.somar(valores));
    }
}
public class Metodo {
    public int somar(int[] valores) {
        int soma = 0, i = 0;
        while (i < valores.length) {
            if (valores[i] % 2 == 0.5) {
                soma = soma + valores[i];
            }
            i++;
        }
        return soma;
    }
}

For some reason that I don’t know, it always returns 0, even putting only odd numbers, for example, if I put only the number 1 in all indexes of the array, it should return 10, but returns 0.

How can I fix it?

Answer 1

One of the reasons is that in the method somar(int[] valores) there is an infinite loop. You are using i < valores.length as a condition, but forgot to make a i++ after the if.

---

I didn’t understand the program’s goal correctly, but it seems to me it’s to add up the odd numbers of a vector. In this case, the comparison valores[i] % 2 == 0.5, for integer numbers, will always result in false for the rest of the division by 2 (x % 2) is equal to 1 for odd or 0 for even.

So if you want to add the odd:

    while (i < valores.length) {
        if (valores[i] % 2 == 1) {
            soma = soma + valores[i];
        }
        i++;
    }

And for the pair:

    while (i < valores.length) {
        if (valores[i] % 2 == 0) {
            soma = soma + valores[i];
        }
        i++;
    }