Error while trying to update table using C#

Question

I created a form to change a table, but my update is not working.

    cnxCli.sel =/*"set dateformat dmy \n"+ */
                "update Cliente" +
                 "set Nome = '" + txtNome.Text +"'," +
                 "Rg = '" + mskRg.Text + "'," +
                 "Cpf ='" + mskCpf.Text + "'," +
                 "Celular ='" + mskCelular + "'," +
                 "Telefone ='" + mskTelefone + "'," +
                 "DataNascimento = '" + mskNascimento.Text + "'," +
                 "Endereco ='" + txtEndereco.Text + "'," +
                 "Bairro='" + txtBairro.Text + "'," +
                 "Cidade='" + "'," +
                 "Cep ='" + mskCep.Text + "'," +
                 "Observacao='" + txtObs.Text + "'" +
                 "where IDCliente =" + IdCliSel;
    cnxCli.selCmd.CommandText = cnxCli.sel;
    bool deuErro = false;
    try
    {
        cnxCli.selCmd.ExecuteNonQuery();
    }
    catch (Exception ex)
    {
        MessageBox.Show(ex.Message);
        deuErro = true;
        //throw;
    }
    if (!deuErro)
        MessageBox.Show("Cadastro do cliente " + IdCliSel + " atualizado com sucesso!");

The exception thrown: System.Data.SqlClient.SqlException - Incorrect syntax near 'Nome'.

For me the syntax seems correct, so much so that I copied the code directly from SQL Server 2014, where I had just run the command.

Answer 1

There is a syntax error because a space is missing in "update Cliente" +, in this way brought it all together.

But this is an even smaller problem, the whole code has several problems.

Never ride a query in this way, it is insecure and disorganized. See in documentation the right way to do it.

There may still be memory leakage.

Even doing it that way could still be simplified, and simpler things make fewer mistakes and when they happen, they’re easier to find.

The way of exception capture is quite wrong. I teach in several responses.

All columns are varchar? It is unlikely. Will give other mistakes by correcting this.

There are other minor problems and something indicates that the rest of the code is bad too. So it accumulates problems and gets tired and thinking that the problem is in the programming language. You have to learn how to do it, it has to be structured, there’s no point following cake recipes.

Answer 2

One should give a space between the table Cliente and the command set:

cnxCli.sel =/*"set dateformat dmy \n"+ */
                "update Cliente" +
                 "set Nome = '"

Change to:

cnxCli.sel =/*"set dateformat dmy \n"+ */
                "update Cliente " + /*<-----Mudei aqui.*/
                 "set Nome = '"