C++ program stops responding when calling a function a second time

Question

I’m doing a simplified game in the style of Pokémon, but is stopping to answer when calling Bootpokemon for the second time, I’m not finding the problem because it works normally with the first and hangs on the second.

The values print is just to test if everything is being passed correctly.

Excerpts from the code:

Main:

int main(int argc, char** argv){
    TipoMove flamethrower; 
    TipoMove fire_blast; 
    TipoMove fly; 
    TipoMove earthquake;

    TipoMove quick_attack;
    TipoMove thunderbolt;
    TipoMove thunder;
    TipoMove skull_bash;

    InicializaMove(&flamethrower, "Flamethrower", 1, 'e', 95); 
    InicializaMove(&fire_blast, "Fire Blast", 2, 'e', 120);
    InicializaMove(&fly, "Fly", 3, 'f', 70);
    InicializaMove(&earthquake, "Earthquake", 4, 'f', 100);

    InicializaMove(&quick_attack, "Quick Attack", 5, 'f', 40);
    InicializaMove(&thunderbolt, "Thunderbolt", 6, 'e', 95);
    InicializaMove(&thunder, "Thunder", 7, 'e', 120);
    InicializaMove(&skull_bash, "Skull Bash", 8, 'f', 100);

    TipoPokemon charizard;
    TipoPokemon pikachu;

    InicializaPokemon(&charizard, 2, "Charizard", 293, 280, 360, 328, 348, 295, flamethrower, fire_blast, fly, earthquake);

    ImprimePokemon(&charizard);

    InicializaPokemon(&pikachu, 1, "pikachu", 229, 196, 274, 306, 218, 218, quick_attack, thunderbolt, thunder, skull_bash);

    ImprimePokemon(&pikachu);


    return 0;
}

Bootpokemon:

void InicializaPokemon(TipoPokemon *poke, int id, string nome, float ataque, float defesa, float vida, float velocidade, float spAtk, float spDef, TipoMove mov0, TipoMove mov1, TipoMove mov2, TipoMove mov3){         

    poke->id = id;
    poke->nome = nome;
    poke->atk = ataque;
    poke->def = defesa;
    poke->hp = vida;
    poke->speed = velocidade;
    poke->sp_atk = spAtk;
    poke->sp_def = spDef;
    poke->moves[0]= mov0;
    poke->moves[1] = mov1;
    poke->moves[2] = mov2;
    poke->moves[3] = mov3;                                                                              
}

Initialize:

void InicializaMove(TipoMove *mov, string n, int id, char t, float pw){
    mov->nome = n;
    mov->id = id;
    mov->tipo = t;
    mov->power = pw;

    cout << "move " << mov->nome << " inicializado " << endl;
}

Full code on Github

Answer 1

The question has already been answered in the comments, but only to contextualize a little:

Behavior Indefinite

You just came across a Behavior Indefinite. This type of behavior occurs when the programmer (nodes) makes a mistake that the compiler is not required to diagnose.

In its specific case, the error was an attempt to access outside the limits of an array. Note that an error will not necessarily occur, and if one occurs (such as a segmentation failure), a debugger will not necessarily point to the correct cause.

How to protect yourself from this kind of mistake?

First, by linking the compiler warnings (and taking them seriously!). In the case of gcc, you must set the flag -Wall.

Second, using safer interfaces. In your specific case, it would be more interesting to use a Std::array instead of a simple list, and use the member function at() instead of operator[] to retrieve/modify the elements, as this function performs limit checking, preventing its program from causing undefined behavior.