Error concatenating more than 9 C#files

Asked

Viewed 105 times

2

PROBLEM

I made a code to concatenate (Merge) pdf files.

The code works in full but when there are more than 10 files, instead of doing in order: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10.

Does so: 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

DOUBT

How can I get around this problem and do it in the right order?

CODE

My code is this:;:

public void MergePDF(string folder, string[] e)
{
    try
    {
        string[] files = e;
        using (FileStream stream = new FileStream(folder, FileMode.Create))
        {
            iTextSharp.text.Rectangle pageSize = new iTextSharp.text.Rectangle(842, 842);

            Document pdfDoc = new Document(pageSize);
            PdfCopy pdf = new PdfCopy(pdfDoc, stream);
            pdfDoc.Open();
            iTextSharp.text.pdf.PdfReader reader;
            foreach (string file in files)
            {
                reader = new iTextSharp.text.pdf.PdfReader(file);
                iTextSharp.text.pdf.PdfReader.unethicalreading = true;

                iTextSharp.text.Rectangle mediabox = reader.GetPageSize(1);

                pdfDoc.SetPageSize(mediabox);
                pdf.AddDocument(reader);
                reader.Dispose();
                pbar.PerformStep();
            }
            pdfDoc.Close();
            pdf.Dispose();
            stream.Dispose();
            succed = 1;
        }
    }
    catch (Exception ex)
    {
        succed = 0;
        MessageBox.Show(ex.ToString(), "Erro", MessageBoxButtons.OK);
    }
}
c# pdf

  • Take a look at these solutions and see if they are useful to you: https://stackoverflow.com/questions/808670/combine-two-or-more-pdfs

  • @Marlonleandro Thanks for the link, but deep down these solutions are similar to my code...

  • Or do you think I should wear a cycle for instead of a cycle foreach ?

  • Use the for and post the return

  • @Focos received the error in CreationTime string does not contain a Definition for Creationtime

  • Yes, I’ve removed the comment, CreationTime would only work if it were FileSystemInfo[], in your case is string[].

  • @Right focus, thanks anyway.

  • I don’t understand... your error an Exception in executing the code or simply respecting the order of the files?

  • 1

    Test this way: var files = e.OrderBy(f => new string(f.Where(char.IsLetter).ToArray()))
 .ThenBy(f =>
 {
 int number;
 if (int.TryParse(new string(f.Where(char.IsDigit).ToArray()), out number))
 return number;
 return -1;
 }).ToList(); In place of string[] files = e;

  • @Leandroangelo is an error regarding the order of the files, it is not an Exception error.

  • That’s right @Focos ! Thank you. Could you post as a reply and explain the code please? It’s easy to copy and paste but it’s hard to understand what we’re using.

Show 6 more comments

1 answer

3


Answer

Change the line:

string[] files = e;

for:

var files = e
            .OrderBy(f => new string(f.Where(char.IsLetter).ToArray()))
            .ThenBy(f => 
                    { int number; 
                      if (int.TryParse(new string(f.Where(char.IsDigit).ToArray()), out number)) 
                          return number; 
                      return -1; 
                    }
                   ).ToList();

Explanation

The code is very simple to understand.

First the array of string (variable and) is ordered by letters through the method .OrderBy(), which is passed as a parameter array of the letters of string.

After the sorting by letters is carried out the sorting by numbers through the method .ThenBy(), checked whether it is possible to convert the digit to int, if so, the number will be returned to be ordered.

Problem

If file names have numbers at the beginning or numbers between letters, may not order correctly.

For example, the following set:

"1c4",
"c20",
"c3",
"c5a"

Results in:

"c3",
"1c4", //Número no começo
"c20",
"c5a" //Número entre letras

Reference

Array.Sort for strings with Numbers

Browser other questions tagged c# pdf

You are not signed in. Login or sign up in order to post.