Are the Unitarian tests correct?

Question

I am participating in a selection process, and one of the criteria is to implement any kind of unit test, I just wonder if it is implemented right the code below, it is working perfectly, I just need to know if it is implemented right.

@RunWith(SpringRunner.class)
@SpringBootTest
@TestPropertySource("classpath:application.properties")
@ContextConfiguration(classes = { AppConfig.class })
@FixMethodOrder(MethodSorters.NAME_ASCENDING)
public class TesteApplicationTests {

    @Autowired
    private PessoaRepository pessoaRepository;

    @Autowired
    private PessoaService pessoaService;

    @Test
    public void testPessoa1Inclusao() throws Exception {
        Pessoa pessoa1 = new Pessoa("Marcelo Dultra", "840.622.210-71");
        this.pessoaService.salvar(pessoa1);
        // Assertions.assertThat(pessoa1.getName()).isNotNull();
    }

    @Test
    public void testPessoa2Exclusao() throws Exception {

        Pessoa pessoa = pessoaRepository.findOne((long) 3);
        pessoaRepository.delete(pessoa);    
    }

    @Test
    public void testPessoa3ExclusaoDaUltima() throws Exception {
        List<Pessoa> todasPessoas = pessoaRepository.findAll();
        Pessoa ultima = todasPessoas.get(todasPessoas.size() - 1);
        pessoaRepository.delete(ultima);    
    }

    @Test
    public void testPessoa4Atualizacao() throws Exception {
        Pessoa pessoa3 = new Pessoa("Ricardo Falcão1", "213.535.690-55");
        this.pessoaService.atualizar(pessoa3.getCodigo().valueOf(4), pessoa3);

    }



}

Answer 1

Based on my comment your question, in addition to reaffirming that unit tests are for testing the business rule and must have both error and accuracy tests, it is nice to put that unit tests should test a small part of the business rule.

My suggestion is that you create a validator class of people. This class will have method of validation of CPF/CNPJ, State Registration, date of birth, e-mail, telephone, the already existence of the CPF/CNPJ inserted and etc. It depends on how rich you want its validations. In the case of deletion, you can place bindings validations of the deleted person with other entities of person as addresses (1 - n), if the deletion is not logical. What would cause problems in the database with the foreign key.

Always try to do a test that the entered value passes and a test that the entered value does not pass (ie the correct is to see error). Add your class of validators friendly messages that suggest to the user how it should fix the error and not simply saying it is wrong.

More materials if you want to read about it:

"Understand once and for all what unit testing is"

"Software Testing"

"TDD Fundamentals of Test-Driven Development"

"What’s up? How do you test your codes?"

Answer 2

From what I’ve observed, what you’ve done is integration tests and not unit tests.

Unit tests cover a small part of the code, are simple and test internal logic of the application commonly related to the business involved, going from the simplest rules (if the field is in the correct format, if the character limit is correct, etc) to the most complex (if the user is blocked, if the user can make a purchase given his credit, etc).

These multi-layer tests are commonly known as integration tests, which is the case with the code you made. The code is making queries to a database (an H2 in memory, I presume). The code also apparently isn’t testing any logic created by you. I’m also not seeing any assert result (the only one in the code is commented), to ensure that the expected behavior has been achieved.

An example of unit testing, in the concept you presented, could be validating the person’s CPF, returning an Exception CpfInvalidoException if invalid:

class PessoaTest {

    @Test(expects = CpfInvalidoException.class);
    public void naoSalvarPessoaComCpfInvalido() {
        PessoaService pessoaService = new PessoaService(mock(PessoaRepository.class));
        pessoaService.salvar(new Pessoa("Marcelo Dultra", "840.622.210"));
    }

}